Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Support newest version of Minikube #1340

Closed
kakkoyun opened this issue Feb 14, 2023 · 3 comments
Closed

ci: Support newest version of Minikube #1340

kakkoyun opened this issue Feb 14, 2023 · 3 comments
Assignees
Labels
area/build-pipeline Something to do with CI and build pipeline good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Feb 14, 2023

The auto-upgrade is broken; apparently, some changes on Minikube causes our end-to-end tests to fail #1425

The root cause needs to be tracked down, and we should check whether we can upgrade to the most recent minikube version.

(I haven't even tested to upgrade the newest version locally).

@kakkoyun kakkoyun added good first issue Good for newcomers help wanted Extra attention is needed area/build-pipeline Something to do with CI and build pipeline labels Feb 14, 2023
@maxbrunet maxbrunet self-assigned this Feb 18, 2023
@maxbrunet
Copy link
Member

Submitted the fixes here: medyagh/setup-minikube#74

@maxbrunet
Copy link
Member

One more bug before we can upgrade: medyagh/setup-minikube#110

@maxbrunet
Copy link
Member

maxbrunet commented Jun 13, 2023

Worked around upstream issue for now

# https://github.com/medyagh/setup-minikube/issues/110
- name: Patch CNI configuration
run: |
jq '
.cniVersion |= if split(".")[:2]|map(tonumber) < [0, 4] then "0.4.0" else . end |
.plugins |= if [select(.[].type == "firewall")]|length == 0 then . + [{ "type": "firewall" }] else . end
' /etc/cni/net.d/1-k8s.conflist | sudo tee /etc/cni/net.d/1-k8s.conflist.patched
sudo mv /etc/cni/net.d/1-k8s.conflist.patched /etc/cni/net.d/1-k8s.conflist
sudo systemctl restart cri-docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-pipeline Something to do with CI and build pipeline good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants