symbolizer: reduce the number of debuginfo copies #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
Dec 6, 2024
pkg/symbolizer/symbolizer.go
Outdated
| return "", nil, nil, fmt.Errorf("create temp file: %w", err) | ||
| } | ||
|
|
||
| fmt.Printf("Copying %s to tmp file %s\n", buildID, f.Name()) |
There was a problem hiding this comment.
can we replace this with a regular log statement?
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
4762250 to
a2198b8
Compare
danipozo
force-pushed
the
reduce-debuginfo-copies-when-symbolizing
branch
from
a2198b8 to
4c37617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the existence of debuginfo files in the temporary directory to reduce the number of copies on each request, which drives high disk usage and latency.