Typed api.storeResult

[mischnic]

Not sure if this is actually a good idea, but I find it very confusing and error-prone that these two cases typecheck just fine

	// Does returns undefined if uncached, but returns a number if cached
    let requestB: void = await tracker.runRequest({
      id: 'abc',
      type: 'mock_request',
      run: async ({api}) => {
        api.storeResult(123);
      },
      input: null,
    });

	// Actually returns undefined if cached
    let requestB: string = await tracker.runRequest({
      id: 'abc',
      type: 'mock_request',
      run: async ({api}) => {
        return 'b'
      },
      input: null,
    });

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.74s	-57.00ms
Cached	384.00ms	-1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	106.00ms	-172.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	107.00ms	-172.00ms 🚀
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	106.00ms	-173.00ms 🚀
dist/legacy/index.b8ae99ba.css	94.00b	+0.00b	301.00ms	+18.00ms ⚠️
dist/modern/index.31cedca9.css	94.00b	+0.00b	300.00ms	+17.00ms ⚠️

React HackerNews ✅

Timings

Description	Time	Difference
Cold	11.26s	-48.00ms
Cached	508.00ms	-8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	1.94m	-1.24s
Cached	2.57s	+57.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description	Time	Difference
Cold	8.15s	-77.00ms
Cached	307.00ms	-8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

[mischnic]

(One unsoundness does remain: runRequest() can still return undefined if the request didn't do .storeResult(), but enforcing that isn't possible with Flow, and the alternative of making the result always ?TResult is very unergonomic.)