Address bug by updating an asset reference and merge conditions #8762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
devongovett
reviewed
Jan 17, 2023
| bundles.set(movingAsset.id, mainNodeId); | ||
| } | ||
| replaceAssetReference(movingAsset, b, a); | ||
| } |
There was a problem hiding this comment.
Probably could merge this loop with the one below but not a big deal
devongovett
approved these changes
Jan 17, 2023
marcins
pushed a commit
to marcins/parcel
that referenced
this pull request
Jul 14, 2023
* upstream/v2: (33 commits) v2.8.3 Changelog for v2.8.3 Address bug by updating an asset reference and merge conditions (parcel-bundler#8762) Fix CSS order when merging type change bundles (parcel-bundler#8766) fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763) Extension: Importers View and separate LSP protocol package (parcel-bundler#8747) Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756) Apply HMR updates in topological order (parcel-bundler#8752) Make extension packaging work (parcel-bundler#8730) Typed api.storeResult (parcel-bundler#8732) Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728) Bump swc (parcel-bundler#8742) Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004) Fix tsc sourcemaps metadata (parcel-bundler#8734) Assigning to `this` in CommonJS (parcel-bundler#8737) Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738) Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731) filter out title execArgv to workers (parcel-bundler#8719) Document more of the BundleGraph class (parcel-bundler#8711) Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357) ...
lettertwo
added a commit
that referenced
this pull request
Nov 6, 2023
* upstream/v2: (128 commits) [webextension] Add support for `chrome_style` (#8867) Switch to SWC minifier by default (#8860) Use BitSet for bundler intersections (#8862) best key logic truncating package names (#8865) Add support for loadConfig to resolver plugins (#8847) Missing edge for multiple targets (#8854) Split large runtime manifest into separate bundles (#8837) Improvements to new resolver (#8844) Fix published files for resolver New resolver implementation in Rust (#8807) Update yarn.lock (#8843) Bump napi-rs to latest (#8838) Support .proxyrc.cjs (#8833) Sort global deps before injecting imports (#8818) Sort CSS module exports (#8817) fix: add extra information to unique bundles (#8784) Don't blow up HMR when <link />s don't have hrefs (#8800) v2.8.3 Changelog for v2.8.3 Address bug by updating an asset reference and merge conditions (#8762) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This pull request addresses issue-8716
To address this I've made sure merged assets are not seen as "bundleRoots" in any related structures, and made sure to update our
assetReferencestructures which helps us map back nodes to the legacyGraph💻 Examples
Test Case
✔️ PR Todo