Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hasOwnProperty #9362

Merged
merged 5 commits into from
Nov 12, 2023
Merged

fix: hasOwnProperty #9362

merged 5 commits into from
Nov 12, 2023

Conversation

gagdiez
Copy link
Contributor

@gagdiez gagdiez commented Nov 4, 2023

The current implementation makes a direct use of hasOwnProperty which misbehaves when a module exports a method named hasOwnProperty see issue 9350.

This commit implements a safer way to call hasOwnProperty.

↪️ Pull Request

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

The current implementation makes a direct use of hasOwnProperty which misbehaves when a module exports a method named `hasOwnProperty` [see issue 9350](#9350).

This commit implements a [safer way to call hasOwnProperty](https://stackoverflow.com/questions/12017693/why-use-object-prototype-hasownproperty-callmyobj-prop-instead-of-myobj-hasow/12017703#12017703).
@mischnic

This comment was marked as resolved.

@mischnic mischnic linked an issue Nov 12, 2023 that may be closed by this pull request
@mischnic mischnic merged commit 7a68dc9 into parcel-bundler:v2 Nov 12, 2023
14 of 16 checks passed
@alshdavid alshdavid mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import react-bootstrap-typeahead
2 participants