Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Display multisig select instead of account select #160

Closed
statictype opened this issue May 4, 2023 · 7 comments
Closed

Display multisig select instead of account select #160

statictype opened this issue May 4, 2023 · 7 comments
Assignees

Comments

@statictype
Copy link
Contributor

In the current flow we have a dropdown where we can select the multisig from which the transfer should happen and a read-only field that shows the member who initiated the transfer (Initiated by).

Screenshot 2023-05-04 at 14 27 11

In order to change the account that initiates the transfer, we need to select it in the main dropdown in the top bar, which means we loose access to the multisig (we only display the ones created by the selected account)

It doesn't really make sense to have a read-only initiator, but be able to select a multisig.
It makes more sense to me to be able to switch between members and have the multisig read-only. this means the /new-transaction page should be coupled to a specific setup.

any thoughts? @Goranch3 @peetzweg

@peetzweg
Copy link
Member

peetzweg commented May 4, 2023

Hm, for me it would make sense to have the initiating account fix. I think I will only log in to a single account to the app. And than the "from" will offer all the multisigs I'm part of.

If I want to change the "initiator" I would need to change the account in the "App Wide Account Dropdown". If this happens during any "wizard" we should redirect the app to the start dashboard.

Everything else like updating the "multisigs available to the user" during account change, during a wizard is a probably a headache. As the newly selected account might not have access to any multisig.

A plain redirect to the starting dashboard feels easy and right to me. 🤷

@statictype
Copy link
Contributor Author

It might makes sense in the future when we allow external addresses, but for now this is an MVP where you can only use accounts from your wallet. We have plans for more fine-grained user roles.

the current flow is like so:

  • user comes to the app and connects wallet
  • an account is selected
  • the setups created by this account are retrieved from the db (not the ones the account is a member of)
  • user clicks on new transaction, but can only initiate it from the account that created the multisig. when they want to change the account in the dropdown, other multisigs are fetched from the DB (the ones that were created by that account)

@statictype
Copy link
Contributor Author

what i'm proposing actually is to make "Initiated by" a dropdown (populated with the members in the selected multisig)

@Goranch3
Copy link

Goranch3 commented May 9, 2023

@statictype sorry for the delayed answer, I see what you mean and it makes sense. The only concern I have is that we are catering more and more to the MVP use-case only, so decisions made for the MVP will have to be re-evaluated moving forward.

@statictype
Copy link
Contributor Author

the changes here are minimal, we can easily switch back.

@Goranch3
Copy link

Goranch3 commented May 9, 2023

that is true, keeping track of all the decisions we need to reevaluate is harder, I'll write down those I can remember

@peetzweg
Copy link
Member

peetzweg commented Jun 5, 2023

closed by #186.

@peetzweg peetzweg closed this as completed Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants