Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build --verifiable command #1511

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix build --verifiable command #1511

merged 1 commit into from
Feb 28, 2024

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Feb 27, 2024

Summary

Closes #_

  • y/n | Does it introduce breaking changes?
  • y/n | Is it dependent on the specific version of ink or pallet-contracts?
    Fix build --verifiable

Description

Cargo contract version 4.0.0-rc.2

cargo contract build --verifiable
causes an issue:

[==] Checking clippy linting rules
error: 'cargo-clippy' is not installed for the toolchain 'stable-x86_64-unknown-linux-gnu'
To install, run `rustup component add clippy`
ERROR: 
ERROR: Failed to read build result from docker build

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed merged commit 2c7d7ef into master Feb 28, 2024
11 checks passed
@smiasojed smiasojed deleted the sm/build-fix branch February 28, 2024 08:23
Build docker image:

```bash
docker buildx build -t paritytech/contracts-verifiable:0.0.1 .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a strange tag. Where does 0.0.1 come from?

Copy link
Collaborator Author

@smiasojed smiasojed Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set a tag to differentiate the locally built image from the one downloaded. It can be any tag, do you want to change it?
maybe: paritytech/contracts-verifiable:0.0.1-local

@SkymanOne SkymanOne mentioned this pull request Feb 28, 2024
@smiasojed smiasojed mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants