Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: generate reference constants for the performance check #59

Closed
Tracked by #209
slumber opened this issue Dec 5, 2021 · 3 comments
Closed
Tracked by #209
Assignees
Labels
enhancement New feature or request

Comments

@slumber
Copy link

slumber commented Dec 5, 2021

paritytech/polkadot#4342 introduces new polkadot-cli command which basically checks if the machine can compile kusama runtime fast enough. For this we need some kind of time limits obtained from the reference machine.
This PR also includes a crate for generating these limits in a file. Is it feasible to extend the bot to do something like:

# checkout the given branch
cd node/test/performance-test
cargo run --release --bin gen-ref-constants
# once it finishes, node/test/performance-test/src/constants.rs is generated
cargo +nightly fmt
# commit new file and push it

I'm not sure since there's

This is a substrate-only bot at the moment.

in the README.

@Vovke Vovke added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Apr 12, 2022
@joao-paulo-parity joao-paulo-parity added the enhancement New feature or request label May 3, 2022
@joao-paulo-parity joao-paulo-parity transferred this issue from paritytech/bench-bot May 12, 2022
@joao-paulo-parity
Copy link
Contributor

So I take it is a new command. If that's right, it could be included in the commandConfigurations.

@mordamax
Copy link
Contributor

mordamax commented Nov 15, 2023

@slumber 1) since kusama/polkadot runtimes are not part of polkadot-sdk, will that be needed for westend & rococo?
2) how often would people need to run this within PR ?

@slumber
Copy link
Author

slumber commented Nov 15, 2023

@slumber 1) since kusama/polkadot runtimes are not part of polkadot-sdk, will that be needed for westend & rococo? 2) how often would people need to run this within PR ?

This command was removed from polkadot cli, hence the issue is no longer relevant

@slumber slumber closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants