Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define events as a single enum #1222

Open
athei opened this issue Apr 22, 2022 · 0 comments
Open

Define events as a single enum #1222

athei opened this issue Apr 22, 2022 · 0 comments
Labels
B-enhancement New feature or request

Comments

@athei
Copy link
Contributor

athei commented Apr 22, 2022

Right now events are declared as individual structs. This is not optimal because it wastes space and doesn't enforce grouping all events in one place. What we should to instead is define them just as the Error type as a single enum. The codegen should make sure that only struct like variants are used so that all fields are properly named.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants