Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls #1379

agryaznov · 2022-09-01T09:32:49Z

Solves #1346

… in on-chain env

examples/contract-transfer/lib.rs

crates/env/src/lib.rs

crates/env/src/engine/off_chain/test_api.rs

examples/contract-transfer/lib.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

crates/env/src/engine/off_chain/test_api.rs

crates/env/src/lib.rs

examples/contract-transfer/lib.rs

crates/env/src/lib.rs

HCastano

Some small things to fix, but looks good!

crates/env/src/engine/off_chain/test_api.rs

examples/contract-transfer/lib.rs

crates/env/src/engine/off_chain/test_api.rs

codecov-commenter · 2022-09-10T12:04:54Z

Codecov Report

Merging #1379 (96908b7) into master (a314b34) will decrease coverage by 25.24%.
The diff coverage is n/a.

❗ Current head 96908b7 differs from pull request most recent head e60a5dc. Consider uploading reports for the commit e60a5dc to get more accurate results

@@             Coverage Diff             @@
##           master    #1379       +/-   ##
===========================================
- Coverage   70.16%   44.92%   -25.25%     
===========================================
  Files         190      189        -1     
  Lines        5940     5888       -52     
===========================================
- Hits         4168     2645     -1523     
- Misses       1772     3243     +1471

Impacted Files	Coverage Δ
crates/env/src/engine/off_chain/test_api.rs	`86.84% <ø> (ø)`
crates/lang/codegen/src/traits.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/env.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/mod.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/enforced_error.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/blake2b.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/storage.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/arg_list.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/contract.rs	`0.00% <0.00%> (-100.00%)`	⬇️
crates/lang/codegen/src/generator/selector.rs	`0.00% <0.00%> (-100.00%)`	⬇️
... and 47 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

armyhaylenko · 2022-09-15T12:02:05Z

hey @agryaznov, we tested out the macro and it does not work.
since the macro is defined as ($contract:ident . $message:ident ( $($params:ty)? ) , $amount:expr), you can't really pass multiple params there, like ink_env::pay_with_call!(contract.foobar(arg1, arg2, arg3.quox), 1000). it'll lead to compile errors. and why is params a type?

… sending payments with contract msg calls (#1379) * first ver.: transfer_in api function implememted but we can't have it in on-chain env * transfer_in moved to test_api * doc + example updated * Update examples/contract-transfer/lib.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * use stmt moved to macro * docs and nitty gritties * moved the macro to the test mod * spell fix * next review round suggestions applied * Use four spaces for macro indentation Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>

* Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls (#1379) * first ver.: transfer_in api function implememted but we can't have it in on-chain env * transfer_in moved to test_api * doc + example updated * Update examples/contract-transfer/lib.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * use stmt moved to macro * docs and nitty gritties * moved the macro to the test mod * spell fix * next review round suggestions applied * Use four spaces for macro indentation Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Allow `pay_with_call` to take multiple arguments (#1401) * Moved constants from `match` to a separate constants (#1418) * fix tests Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Andrew Jones <ascjones@gmail.com>

agryaznov added 4 commits September 1, 2022 10:32

first ver.: transfer_in api function implememted but we can't have it…

681a60f

… in on-chain env

transfer_in moved to test_api

8800ba7

Merge branch 'master' into ag-call-payable-offchain

2b47fb9

doc + example updated

c49d0ff

agryaznov marked this pull request as ready for review September 1, 2022 09:38

agryaznov requested review from cmichi, ascjones and HCastano as code owners September 1, 2022 09:38

HCastano reviewed Sep 1, 2022

View reviewed changes

examples/contract-transfer/lib.rs Outdated Show resolved Hide resolved

crates/env/src/lib.rs Outdated Show resolved Hide resolved

crates/env/src/engine/off_chain/test_api.rs Show resolved Hide resolved

examples/contract-transfer/lib.rs Outdated Show resolved Hide resolved

agryaznov and others added 3 commits September 1, 2022 21:31

Update examples/contract-transfer/lib.rs

541d110

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

use stmt moved to macro

71ea6bf

Merge branch 'master' into ag-call-payable-offchain

59e77f8

agryaznov requested a review from HCastano September 1, 2022 19:05

HCastano reviewed Sep 2, 2022

View reviewed changes

crates/env/src/engine/off_chain/test_api.rs Show resolved Hide resolved

crates/env/src/lib.rs Outdated Show resolved Hide resolved

examples/contract-transfer/lib.rs Outdated Show resolved Hide resolved

crates/env/src/lib.rs Outdated Show resolved Hide resolved

agryaznov added 4 commits September 6, 2022 21:22

Merge branch 'master' into ag-call-payable-offchain

e592080

docs and nitty gritties

cd9ca7f

moved the macro to the test mod

40e827f

spell fix

65d7d21

agryaznov requested a review from HCastano September 6, 2022 19:07

HCastano approved these changes Sep 7, 2022

View reviewed changes

agryaznov added 2 commits September 10, 2022 14:18

Merge branch 'master' into ag-call-payable-offchain

655e59c

next review round suggestions applied

96908b7

Use four spaces for macro indentation

e60a5dc

agryaznov merged commit d42bfbf into master Sep 13, 2022

agryaznov deleted the ag-call-payable-offchain branch September 13, 2022 15:22

agryaznov mentioned this pull request Sep 13, 2022

smart contract's balance doesn't change in tests #1346

Closed

HCastano mentioned this pull request Sep 16, 2022

Allow pay_with_call to take multiple arguments #1401

Merged

ascjones mentioned this pull request Sep 20, 2022

Release v4.0.0 alpha.2 #1408

Merged

ascjones mentioned this pull request Sep 21, 2022

Release v4.0.0-alpha.3 #1409

Merged

agryaznov mentioned this pull request Oct 18, 2022

Backport #1379 #1401 #1418 into v3.x.x and fix tests #1439

Merged

ascjones mentioned this pull request Feb 15, 2023

Release v4.0.0 #1653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls #1379

Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls #1379

agryaznov commented Sep 1, 2022

HCastano left a comment

codecov-commenter commented Sep 10, 2022 •

edited

Loading

armyhaylenko commented Sep 15, 2022

Add ink_env::pay_with_call! helper macro for off-chain emulation of sending payments with contract msg calls #1379

Add ink_env::pay_with_call! helper macro for off-chain emulation of sending payments with contract msg calls #1379

Conversation

agryaznov commented Sep 1, 2022

HCastano left a comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 10, 2022 • edited Loading

Codecov Report

armyhaylenko commented Sep 15, 2022

Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls #1379

Add `ink_env::pay_with_call!` helper macro for off-chain emulation of sending payments with contract msg calls #1379

codecov-commenter commented Sep 10, 2022 •

edited

Loading