Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missed WhereClosure for the generics into storage_item #1536

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Dec 14, 2022

Added missed WhereClosure for the generics. Tested this case via documentation

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a contract which shows what the problem is/was?

If I'd be inclined to add it as a UI test

@HCastano HCastano changed the title Bugfix: Added missed WhereClosure for the generics into storage_item Added missed WhereClosure for the generics into storage_item Dec 16, 2022
@HCastano HCastano added the C-bug Something isn't working label Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1536 (f9b34ff) into master (2cd3a0c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
- Coverage   71.62%   71.58%   -0.05%     
==========================================
  Files         205      205              
  Lines        6295     6295              
==========================================
- Hits         4509     4506       -3     
- Misses       1786     1789       +3     
Impacted Files Coverage Δ
crates/ink/macro/src/lib.rs 100.00% <ø> (ø)
crates/ink/ir/src/ir/storage_item/mod.rs 75.00% <100.00%> (+1.08%) ⬆️
crates/allocator/src/bump.rs 88.23% <0.00%> (-1.85%) ⬇️
crates/ink/ir/src/ir/attrs.rs 81.99% <0.00%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xgreenx
Copy link
Collaborator Author

xgreenx commented Dec 16, 2022

Previously it was not possible=)
image

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the doc tests are good enough to prove this works

@ascjones ascjones merged commit dda44c6 into use-ink:master Jan 3, 2023
@xgreenx xgreenx deleted the bugfix/missed-where-clousure branch January 3, 2023 13:46
@ascjones ascjones mentioned this pull request Jan 12, 2023
HCastano pushed a commit that referenced this pull request Jan 23, 2023
@HCastano HCastano mentioned this pull request Jan 24, 2023
@ascjones ascjones mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants