-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missed WhereClosure
for the generics into storage_item
#1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a contract which shows what the problem is/was?
If I'd be inclined to add it as a UI test
WhereClosure
for the generics into storage_item
WhereClosure
for the generics into storage_item
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
- Coverage 71.62% 71.58% -0.05%
==========================================
Files 205 205
Lines 6295 6295
==========================================
- Hits 4509 4506 -3
- Misses 1786 1789 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the doc tests are good enough to prove this works
Added missed
WhereClosure
for the generics. Tested this case via documentation