-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain Extension: Evaluation of method return type at compile time #1569
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 64.68% 71.53% +6.85%
==========================================
Files 207 205 -2
Lines 6417 6268 -149
==========================================
+ Hits 4151 4484 +333
+ Misses 2266 1784 -482
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of the > 80 CPL, but I see the surrounding code is using it too.
This PR closes #952
It introduces breaking changes to chain extension macro API:
returns_result
flag has been removedSince this PR,
Result<O, E>
return type is detected and handled at the compile time.If
handle_status
is set to true, the return type will still be wrapped intoResult
as before.Tasks: