Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ink_e2e] expose call dry-run method #1624

Merged
merged 28 commits into from
Jan 31, 2023
Merged

[ink_e2e] expose call dry-run method #1624

merged 28 commits into from
Jan 31, 2023

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jan 26, 2023 •
edited
Loading

As suggested by @athei.

Also closes #1620

cmichi
cmichi reviewed Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API lgtm!

@athei
Copy link
Contributor

athei commented Jan 27, 2023

Looks good. Can you fix #1620 as a drive by? I think you might be exposing more types now (the dry run type) which might not be exposed.

@ascjones ascjones marked this pull request as ready for review January 30, 2023 14:54
@ascjones
Copy link
Collaborator Author

Completed updating the remaining examples

@ascjones
Copy link
Collaborator Author

ascjones commented Jan 30, 2023 •
edited
Loading

Looks good. Can you fix #1620 as a drive by? I think you might be exposing more types now (the dry run type) which might not be exposed.

7916ff5

Looking at the docs for the first time, they could do with some fleshing out, but not something I am going to do here.

athei
athei approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

HCastano
HCastano approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

crates/e2e/src/client.rs Outdated Show resolved Hide resolved
@ascjones ascjones merged commit 3cec278 into master Jan 31, 2023
@ascjones ascjones deleted the aj/e2e-call-dry-run branch January 31, 2023 20:11
@ascjones ascjones mentioned this pull request Feb 1, 2023
Merged
@ascjones ascjones mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmichi cmichi cmichi left review comments

@athei athei athei approved these changes

@HCastano HCastano HCastano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ink_e2e: Return values of Client methods are not available in rust docs
4 participants
@ascjones @athei @cmichi @HCastano