-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict syntax for setting ink! e2e test node to auto #2146
Restrict syntax for setting ink! e2e test node to auto #2146
Conversation
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Mon Mar 11 10:15:23 CET 2024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
- Coverage 53.76% 53.72% -0.05%
==========================================
Files 224 224
Lines 7084 7084
Branches 3129 3129
==========================================
- Hits 3809 3806 -3
- Misses 3275 3278 +3 ☔ View full report in Codecov by Sentry. |
@davidsemakula Can you make sure this is reflected in the 5.x part of |
Summary
Closes #_
cargo-contract
orpallet-contracts
?Description
#[ink_e2e::test(backend(node))]
and#[ink_e2e::test(backend(node(auto)))]
are valid syntax for setting the e2e test node to auto, this PR removes the latter syntax.#[ink_e2e::test(backend(node(url = ..)))]
)See also #2143 for a similar change
Checklist before requesting a review
CHANGELOG.md