Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-response: Provide more details into rejected requests for a high request failure #188

Closed
1 task done
Tracked by #140
lexnv opened this issue Jul 30, 2024 · 0 comments · Fixed by #227
Closed
1 task done
Tracked by #140
Assignees
Labels
enhancement New feature or request

Comments

@lexnv
Copy link
Collaborator

lexnv commented Jul 30, 2024

Substrate presents many rejected connections, especially for the sync protocol.
The metrics are configured here in substrate.

Screenshot 2024-07-30 at 15 17 25

Running libp2p side by side with litep2p, we can observe from the previous figure a very high number of requests that are marked as "rejected".

Provide more details into rejected requests by enriching the RequestResponseError::Rejected with specific details:

  • is the failure due to opening a substream?
  • is the connection closed and we reject all active requests?
  • is this a dial failure and we reported back immediately? etc

Detected while testing and debugging:

Tasks

  1. enhancement
    lexnv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant