Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parity-util-mem] consider using zeroize crate #181

Closed
ordian opened this issue Jun 22, 2019 · 4 comments · Fixed by #183
Closed

[parity-util-mem] consider using zeroize crate #181

ordian opened this issue Jun 22, 2019 · 4 comments · Fixed by #183

Comments

@ordian
Copy link
Member

ordian commented Jun 22, 2019

https://github.com/iqlusioninc/crates/tree/develop/zeroize seems to be the best option available atm.

Also, https://github.com/iqlusioninc/crates/tree/develop/secrecy could replace our Secret type.

@dvdplm
Copy link
Contributor

dvdplm commented Jun 23, 2019

I looked at zeroize previously and I think it's a great crate and you are probably right that we should use it. I particularly like the extensive docs and general willingness of the author to talk and educate about these issues. At the time I held back because I saw some code that was not clear to me (this) and I didn't want to use code that I do not understand fully. That said, I can definitely be convinced!

The discussion about Secret is possibly slightly more involved as what we have in parity-crypto is sort of a mirror of what we have in ethcore/crypto. The plan is – at least in my head – to move code from there to parity-crypto and @cheme has essentially done that already but it's quite an invasive change so I think it's good to try to do it piece by piece and his approach in that branch is also something I need to review and think through carefully (mostly because I'm slow and ignorant, I don't think there's anything necessarily wrong with it).

@dvdplm
Copy link
Contributor

dvdplm commented Jun 23, 2019

(So maybe we should split out the secrecy conversation to its own ticket?)

@niklasad1
Copy link
Member

/cc @twittner

Any thoughts on zeroize? (I know you implemented something similar in parity-ethereum)

@twittner
Copy link
Contributor

@niklasad1: I can only recommend it. We use it in rust-libp2p and I can think of no reason not to use it here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants