Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

refactor(trim_right_matches -> trim_end_matches) #10159

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

niklasad1
Copy link
Collaborator

Fixes the following warnings, only shown on nightly yet (will be deprecated in Rust 1.33):

warning: use of deprecated item 'core::str::<impl str>::trim_right_matches': superseded by `trim_end_matches`                                                                                         
  --> rpc/src/v1/types/transaction_request.rs:60:22
   |
60 |     String::from(string.trim_right_matches('0')
   |                         ^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(deprecated)] on by default

warning: use of deprecated item 'core::str::<impl str>::trim_right_matches': superseded by `trim_end_matches`                                                                                         
  --> rpc/src/v1/types/transaction_request.rs:61:4
   |
61 |         .trim_right_matches('.'))
   |          ^^^^^^^^^^^^^^^^^^

@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jan 9, 2019
@5chdn 5chdn added this to the 2.4 milestone Jan 10, 2019
@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Jan 10, 2019
@5chdn 5chdn merged commit 38af7f3 into master Jan 10, 2019
@5chdn 5chdn deleted the replace-deprecated-trim-right-matches branch January 10, 2019 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants