This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix(ManageNetwork): replace Range with RangeInclusive #10209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A0-pleasereview 🤓
niklasad1
commented
Jan 17, 2019
| /// Note that `range.end` is *exclusive*. | ||
| // TODO: Range should be changed to RangeInclusive once stable (https://github.com/rust-lang/rust/pull/50758) | ||
| fn num_peers_range(&self) -> Range<u32>; | ||
| fn num_peers_range(&self) -> RangeInclusive<u32>; | ||
| /// Get network context for protocol. |
There was a problem hiding this comment.
IMHO, the return type RangeInclusive makes it clear that the range is inclusive thus I removed the comment
niklasad1
commented
Jan 17, 2019
Fixes `TODO: Range should be changed to RangeInclusive once stable (https://github.com/rust-lang/rust/pull/50758)`
niklasad1
force-pushed
the
network-make-peer-range-inclusive
branch
from
4a675b7
to
f8f1adb
Compare
ordian
approved these changes
Jan 18, 2019
ordian
reviewed
Jan 18, 2019
* RangeInclusive::end() is inclusive which means that if start and end is equal the `debug_assert(range.end() > range.start()` will fail which is shouldn't
ordian
added
A8-looksgood 🦄
tomaka
approved these changes
Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
TODO: Range should be changed to RangeInclusive once stable (https://github.com/rust-lang/rust/pull/50758)