This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix(osx and windows builds): bump parity-daemonize #10291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
added
A0-pleasereview 🤓
|
Looks like it's building fine on my Mac now. |
|
It fails because of the CI is running If we can bump to |
|
why is CI using outdated rust versions @fevo1971 ? |
on mac & windows rust is updated daylay (at ~23:00h), for the docker image parity/rust:gitlab-ci used for all other builds this is not the case (embarrassingly for some quite some time). i coordinated with @TriplEight to finish his work on the new docker image (based on the rust:stable image). |
jam10o-new
approved these changes
Feb 6, 2019
ordian
approved these changes
Feb 6, 2019
ordian
added
A8-looksgood 🦄
niklasad1
force-pushed
the
bump-parity-daemonize
branch
from
6caab1f
to
42f3d6c
Compare
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: fix: parity-clib/examples/cpp/CMakeLists.txt (#10313) CI optimizations (#10297) Increase number of requested block bodies in chain sync (#10247) Deprecate account management (#10213) Properly handle check_epoch_end_signal errors (#10015) fix(osx and windows builds): bump parity-daemonize (#10291) Add missing step for Using `systemd` service file (#10175) Call private contract methods from another private contract (read-only) (#10086) update ring to 0.14 (#10262) fix(secret-store): deprecation warning (#10301) Update to jsonrpc-derive 10.0.2, fixes aliases bug (#10300) Convert to jsonrpc-derive, use jsonrpc-* from crates.io (#10298)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix
WindowsandOSXbuilds/cc @5chdn @ddorgan can you help me run this on Windows and OSX? Thanks