This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Revive parity_setMinGasPrice RPC call #10294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @HCastano signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
|
It looks like @HCastano signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
tomusdrw
reviewed
Feb 4, 2019
ethcore/src/miner/miner.rs
Outdated
|
|
||
| let txq = self.transaction_queue.clone(); | ||
| let mut options = self.options.pool_verification_options.clone(); | ||
| self.gas_pricer.lock().recalibrate(move |gas_price| { |
There was a problem hiding this comment.
Is it worth keeping it DRY? and re-using the same method as for per-block update?
There was a problem hiding this comment.
We only call recalibrate() twice, so for now I'm going to say no unless somebody else has a strong opinion about it.
tomusdrw
added
A3-inprogress ⏳
tomusdrw
approved these changes
Feb 5, 2019
HCastano
added
A0-pleasereview 🤓
5chdn
added
A8-looksgood 🦄
ordian
approved these changes
Feb 11, 2019
5chdn
added
A7-looksgoodcantmerge 🙄
|
@HCastano seems like the merge went wrong, can you check? |
tomusdrw
added
A7-looksgoodtestsfail 🤖
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: no volumes are needed, just run -v volume:/path/in/the/container (#10345) Fixed misstype (#10351) snap: prefix version and populate candidate channel (#10343) Bundle protocol and packet_id together in chain sync (#10315) role back docker build image and docker deploy image to ubuntu:xenial based (#10338) change docker image based on debian instead of ubuntu due to the chan… (#10336) Don't add discovery initiators to the node table (#10305) fix(docker): fix not receives SIGINT (#10059) snap: official image / test (#10168) fix(add helper for timestamp overflows) (#10330) Additional error for invalid gas (#10327) Revive parity_setMinGasPrice RPC call (#10294) Add Statetest support for Constantinople Fix (#10323) fix(parity-clib): grumbles that were not addressed in #9920 (#10154) fix(light-rpc): Make `light_sync` generic (#10238) fix publish job (#10317) Secure WS-RPC: grant access to all apis (#10246) Make specification of protocol in SyncRequester::send_request explicit (#10295)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RPC call was deprecated a while back during a refactoring, but there's been a feature request (#9125) wanting it to be restored.
This PR gives the people what they want.