Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add message to IO errors #10324

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Add message to IO errors #10324

merged 1 commit into from
Feb 18, 2019

Conversation

Pzixel
Copy link
Contributor

@Pzixel Pzixel commented Feb 11, 2019

When I migrated from 2.0.X to 2.1.X I faced an error "Something went wrong". Unfortunately, the original error gets rewritten with useless message. This PR makes original error preserved instead.

@parity-cla-bot
Copy link

It looks like @Pzixel hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@Pzixel
Copy link
Contributor Author

Pzixel commented Feb 11, 2019

[clabot:check]

@parity-cla-bot
Copy link

It looks like @Pzixel signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@Pzixel
Copy link
Contributor Author

Pzixel commented Feb 11, 2019 •
edited
Loading

image

There is 52 more issues in other modules. I think they should be addressed as well. There is nothing worse than useless "oops" error message.

Searching by .map_err(|_| gives even more: 128 hits.

@jam10o-new jam10o-new added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 11, 2019
@5chdn 5chdn added this to the 2.4 milestone Feb 11, 2019
@Pzixel Pzixel mentioned this pull request Feb 18, 2019
Closed
ascjones
ascjones approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 18, 2019
@ascjones ascjones mentioned this pull request Feb 18, 2019
Closed
@ordian ordian merged commit ca67dc2 into openethereum:master Feb 18, 2019
ordian added a commit that referenced this pull request Apr 5, 2019
@ordian
Merge branch 'master' into ao-lmdb
b2519f6 
* master:
  Add message to IO errors (#10324)
  chore(bump parity-daemonize): require rust >= 1.31 (#10359)
  SecretStore: use in-memory transport in cluster tests (#9850)
  Add fields to `memzero`'s Cargo.toml (#10362)
  snap: release untagged versions from branches to the candidate snap channel (#10357)
  fix(compilation warns): `no-default-features` (#10346)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Pzixel @parity-cla-bot @ascjones @ordian @5chdn @jam10o-new