Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

snap: prefix version and populate candidate channel #10343

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Feb 13, 2019

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 13, 2019
@5chdn 5chdn added this to the 2.4 milestone Feb 13, 2019
@General-Beck
Copy link
Contributor

@5chdn and how we will solve this question now?
#9771 (comment)

@5chdn
Copy link
Contributor Author

5chdn commented Feb 13, 2019

@5chdn and how we will solve this question now?
#9771 (comment)

@ElOpio is maintainer but we still have publishing access. So, our gitlab script directly creates a release on snapcraft.

Copy link
Collaborator

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good if we are okay with:

Pushing parity_2.2.10_amd64.snap
After pushing, an attempt will be made to release to 'stable'
Preparing to push '/builds/parity/parity-ethereum/parity_2.2.10_amd64.snap' to the store.
Pushing parity_2.2.10_amd64.snap [                                       ]   0%
Pushing parity_2.2.10_amd64.snap [                                       ]   1%
Pushing parity_2.2.10_amd64.snap [                                       ]   2%
Pushing parity_2.2.10_amd64.snap [=                                      ]   3%
Pushing parity_2.2.10_amd64.snap [=                                      ]   4%
Pushing parity_2.2.10_amd64.snap [=                                      ]   5%
Pushing parity_2.2.10_amd64.snap [==                                     ]   6%
Pushing parity_2.2.10_amd64.snap [==                                     ]   7%
Pushing parity_2.2.10_amd64.snap [===                                    ]   8%
Pushing parity_2.2.10_amd64.snap [===                                    ]   9%
Pushing parity_2.2.10_amd64.snap [===                                    ]  10%
Pushing parity_2.2.10_amd64.snap [====                                   ]  11%
Pushing parity_2.2.10_amd64.snap [====                                   ]  12%
Pushing parity_2.2.10_amd64.snap [=====                                  ]  13%
Pushing parity_2.2.10_amd64.snap [=====                                  ]  14%
Pushing parity_2.2.10_amd64.snap [=====                                  ]  15%
Pushing parity_2.2.10_amd64.snap [======                                 ]  16%
Pushing parity_2.2.10_amd64.snap [======                                 ]  17%
Pushing parity_2.2.10_amd64.snap [=======                                ]  18%
Pushing parity_2.2.10_amd64.snap [=======                                ]  19%
Pushing parity_2.2.10_amd64.snap [=======                                ]  20%
Pushing parity_2.2.10_amd64.snap [========                               ]  21%
Pushing parity_2.2.10_amd64.snap [========                               ]  22%
Pushing parity_2.2.10_amd64.snap [=========                              ]  23%
Pushing parity_2.2.10_amd64.snap [=========                              ]  24%
Pushing parity_2.2.10_amd64.snap [=========                              ]  25%
Pushing parity_2.2.10_amd64.snap [==========                             ]  26%
Pushing parity_2.2.10_amd64.snap [==========                             ]  27%
Pushing parity_2.2.10_amd64.snap [===========                            ]  28%
Pushing parity_2.2.10_amd64.snap [===========                            ]  29%
Pushing parity_2.2.10_amd64.snap [===========                            ]  30%
Pushing parity_2.2.10_amd64.snap [============                           ]  31%
Pushing parity_2.2.10_amd64.snap [============                           ]  32%
Pushing parity_2.2.10_amd64.snap [============                           ]  33%
Pushing parity_2.2.10_amd64.snap [=============                          ]  34%
Pushing parity_2.2.10_amd64.snap [=============                          ]  35%
Pushing parity_2.2.10_amd64.snap [==============                         ]  36%
Pushing parity_2.2.10_amd64.snap [==============                         ]  37%
Pushing parity_2.2.10_amd64.snap [==============                         ]  38%
Pushing parity_2.2.10_amd64.snap [===============                        ]  39%
Pushing parity_2.2.10_amd64.snap [===============                        ]  40%
Pushing parity_2.2.10_amd64.snap [================                       ]  41%
Pushing parity_2.2.10_amd64.snap [================                       ]  42%
Pushing parity_2.2.10_amd64.snap [================                       ]  43%
Pushing parity_2.2.10_amd64.snap [=================                      ]  44%
Pushing parity_2.2.10_amd64.snap [=================                      ]  45%
Pushing parity_2.2.10_amd64.snap [==================                     ]  46%
Pushing parity_2.2.10_amd64.snap [==================                     ]  47%
Pushing parity_2.2.10_amd64.snap [==================                     ]  48%
Pushing parity_2.2.10_amd64.snap [===================                    ]  49%
Pushing parity_2.2.10_amd64.snap [===================                    ]  50%
Pushing parity_2.2.10_amd64.snap [====================                   ]  51%
Pushing parity_2.2.10_amd64.snap [====================                   ]  52%
Pushing parity_2.2.10_amd64.snap [====================                   ]  53%
Pushing parity_2.2.10_amd64.snap [=====================                  ]  54%
Pushing parity_2.2.10_amd64.snap [=====================                  ]  55%
Pushing parity_2.2.10_amd64.snap [======================                 ]  56%
Pushing parity_2.2.10_amd64.snap [======================                 ]  57%
Pushing parity_2.2.10_amd64.snap [======================                 ]  58%
Pushing parity_2.2.10_amd64.snap [=======================                ]  59%
Pushing parity_2.2.10_amd64.snap [=======================                ]  60%
Pushing parity_2.2.10_amd64.snap [=======================                ]  61%
Pushing parity_2.2.10_amd64.snap [========================               ]  62%
Pushing parity_2.2.10_amd64.snap [========================               ]  63%
Pushing parity_2.2.10_amd64.snap [=========================              ]  64%
Pushing parity_2.2.10_amd64.snap [=========================              ]  65%
Pushing parity_2.2.10_amd64.snap [=========================              ]  66%
Pushing parity_2.2.10_amd64.snap [==========================             ]  67%
Pushing parity_2.2.10_amd64.snap [==========================             ]  68%
Pushing parity_2.2.10_amd64.snap [===========================            ]  69%
Pushing parity_2.2.10_amd64.snap [===========================            ]  70%
Pushing parity_2.2.10_amd64.snap [===========================            ]  71%
Pushing parity_2.2.10_amd64.snap [============================           ]  72%
Pushing parity_2.2.10_amd64.snap [============================           ]  73%
Pushing parity_2.2.10_amd64.snap [=============================          ]  74%
Pushing parity_2.2.10_amd64.snap [=============================          ]  75%
Pushing parity_2.2.10_amd64.snap [=============================          ]  76%
Pushing parity_2.2.10_amd64.snap [==============================         ]  77%
Pushing parity_2.2.10_amd64.snap [==============================         ]  78%
Pushing parity_2.2.10_amd64.snap [===============================        ]  79%
Pushing parity_2.2.10_amd64.snap [===============================        ]  80%
Pushing parity_2.2.10_amd64.snap [===============================        ]  81%
Pushing parity_2.2.10_amd64.snap [================================       ]  82%
Pushing parity_2.2.10_amd64.snap [================================       ]  83%
Pushing parity_2.2.10_amd64.snap [=================================      ]  84%
Pushing parity_2.2.10_amd64.snap [=================================      ]  85%
Pushing parity_2.2.10_amd64.snap [=================================      ]  86%
Pushing parity_2.2.10_amd64.snap [==================================     ]  87%
Pushing parity_2.2.10_amd64.snap [==================================     ]  88%
Pushing parity_2.2.10_amd64.snap [==================================     ]  89%
Pushing parity_2.2.10_amd64.snap [===================================    ]  90%
Pushing parity_2.2.10_amd64.snap [===================================    ]  91%
Pushing parity_2.2.10_amd64.snap [====================================   ]  92%
Pushing parity_2.2.10_amd64.snap [====================================   ]  93%
Pushing parity_2.2.10_amd64.snap [====================================   ]  94%
Pushing parity_2.2.10_amd64.snap [=====================================  ]  95%
Pushing parity_2.2.10_amd64.snap [=====================================  ]  96%
Pushing parity_2.2.10_amd64.snap [====================================== ]  97%
Pushing parity_2.2.10_amd64.snap [====================================== ]  98%
Pushing parity_2.2.10_amd64.snap [====================================== ]  99%
Pushing parity_2.2.10_amd64.snap [=======================================] 100%
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Ready to release!
Revision 15812 of 'parity' created.
Track    Arch    Channel    Version                 Revision
latest   amd64   stable     2.2.10                  15812
                 candidate  v2.2.9                  15738
                 beta       2.3.3                   15810
                 edge       2.4.0-ea589a1-20190213  15811
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing.../                                                                 
Processing...-                                                                 
Processing...\                                                                 
Processing...|                                                                 
Processing...|                                                                 

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 13, 2019
@5chdn 5chdn merged commit 5123430 into master Feb 13, 2019
@5chdn 5chdn deleted the a5-scripts-snapcraft branch February 13, 2019 14:52
thefallentree pushed a commit to goerli/parity-goerli that referenced this pull request Feb 14, 2019
* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*
thefallentree pushed a commit to goerli/parity-goerli that referenced this pull request Feb 14, 2019
* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*
5chdn added a commit that referenced this pull request Feb 14, 2019
* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*
@5chdn 5chdn mentioned this pull request Feb 14, 2019
5chdn added a commit that referenced this pull request Feb 14, 2019
* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*
@5chdn 5chdn mentioned this pull request Feb 14, 2019
5chdn added a commit that referenced this pull request Feb 14, 2019
* version: bump stable to 2.2.11

* snap: prefix version and populate candidate channel (#10343)

* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*

* no volumes are needed, just run -v volume:/path/in/the/container (#10345)
5chdn added a commit that referenced this pull request Feb 14, 2019
* version: bump beta to 2.3.4

* snap: prefix version and populate candidate channel (#10343)

* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*

* no volumes are needed, just run -v volume:/path/in/the/container (#10345)
sorpaas pushed a commit that referenced this pull request Mar 26, 2019
* fix broken sync

* correct seal fields

* ethcore: fix comment

* parity: remove duplicate params

* clique: fix whitespaces

* ethcore: fix goerli chain spec

* refactor signer_snapshot into pending/finalized state

* move close_block_extra_data after seal is applied

* refactor most of the logic into the signer_snapshot

* clique: refactor locking logic out of the consensus engine interface

* Fix jsonspec and add an unittest

* Replace space with tabs

* Unbroke sync

* Fix broken sync

* 1/2 state tracking without votes

* 2/2 implement vote tracking

* ci: use travis for goerli

* ci: setup a clique network

* ci: sync a görli node

* add clique deploy script

* ci: fix paths in clique deploy script

* ci: use docker compose

* ci: fix travis job names

* ci: fix build deps

* ci: massively reduce tests

* Revert "ci: massively reduce tests"

This reverts commit 6369f0b.

* ci: run cargo test directly

* ci: separate build and test stages

* ci: cache rust installation

* ci: simplify ci stages

* ci: make clique deploy script executable

* ci: shutdown goerli sync after 20min

* ci: remove slow sync stage

* ci: use timeout to finish jobs

* ci: fix build path

* ci: use absolute paths to end this confusion

* ci: add geth and parity to path

* ci: be more verbose

* ci: allow for more relaxed caching timeout

* ci: update repositories for custom ppa

* ci: fix typo in file name

* ci: fix docker compose file

* ci: add ethkey to docker

* ci: make sure deploy script is up to date with upstream

* ci: stop docker container after certain time

* ci: force superuser to update permissions on docker files

* ci: reduce run time of script to ~30 min

* ci: remove duplicate caching in travis

* remove trace statements

* clique: add more validation involving the recent signer list

* ethcore: enable constantinople for rinkeby

* ethcore: fix whitespaces in rinkeby spec

* ethcore: reformat goerli.json

* Revert "ci: remove duplicate caching in travis"

This reverts commit a562838.

* tmp commit

* another tmp commit

* it builds!

* add sealing capabilities

* add seal_header hook to allow separation of block seal/importing code paths

* clique: remove populate_from_parent.

* add panic

* make turn delay random

* initialize OpenBlock properly in 'enact'

* misc: remove duplicate lines

* misc: fix license headers

* misc: convert spaces to tabs

* misc: fix tabs

* Update Cargo.toml

* Update Cargo.toml

* Update Cargo.toml

* clique: ensure validator restores state before trying to seal

* clique: make 'state' return an Error.  Make some error messages more clear

* Fix compile error after rebase & toolchain upgrade

* fix a bunch of import warnings

* Refactor code

* Fix permissions

* Refactoring syncing

* Implement full validator checks

* Refactor util functions to seperate file

* mining 1

* ethcore: add chainspec for kotti

* ethcore: rename pre-goerli configs

* ethcore: load kotti chain spec

* cli: add kotti to params

* Implement working local sealing

* making sealing & syncing work together

* Relax timestamp checking

* ethcore: prepare for the real goerli to launch

* Implement NOTURN wiggle properly & cleanupnup warnings

* Implement vote casting

* Update docs & skip signing if no signer

* Optimize step-service interval

* Record state on local sealed block

* Fix script filemode

* Cleaning up codebase

* restore enact trace logging

* Delete clique.sh and move sync.sh

* remove travis.yml

* Remove dead code

* Cleanup compile warning

* address review comments

* adding more comments and removing unwrap()

* ci: remove sync script

* Address review comments

* fix compile error

* adding better debugging for timing

* Implement an dedicated thread for sealing timing

* fix(add helper for timestamp overflows) (#10330)

* fix(add helper timestamp overflows)

* fix(simplify code)

* fix(make helper private)

* snap: official image / test (#10168)

* official image / test

* fix / test

* bit more necromancy

* fix paths

* add source bin/df /test

* add source bin/df /test2

* something w paths /test

* something w paths /test

* add source-type /test

* show paths /test

* copy plugin /test

* plugin -> nil

* install rhash

* no questions while installing rhash

* publish snap only for release

* fix(docker): fix not receives SIGINT (#10059)

* fix(docker): fix not receives SIGINT

* fix: update with reviews

* update with review

* update

* update

* Don't add discovery initiators to the node table (#10305)

* Don't add discovery initiators to the node table

* Use enums for tracking state of the nodes in discovery

* Dont try to ping ourselves

* Fix minor nits

* Update timeouts when observing an outdated node

* Extracted update_bucket_record from update_node

* Fixed typo

* Fix two final nits from @todr

* change docker image based on debian instead of ubuntu due to the chan… (#10336)

* change docker image based on debian instead of ubuntu due to the changes of the build container

* role back docker build image and docker deploy image to ubuntu:xenial based (#10338)

* Bundle protocol and packet_id together in chain sync (#10315)

Define a new `enum` where devp2p subprotocol packet ids (currently eth and par) are defined. Additionally provide functionality to query id value and protocol of a given id object.

* snap: prefix version and populate candidate channel (#10343)

* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*

* addressing review comments

* engine: fix copyright header

* scripts: restore permissions on sign command

* ethcore: enforce tabs

* ethcore: enforce tabs

* ethcore: enforce tabs

* addressing comments

* addressing comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* json-spec: fix clique epoch to non-zero u64

* ci: enable travis for parity goerli

* ci: don't separate build and test step

* ci: don't run c++ tests on travis

* ci: simplify cargo test to squeeze into travis timeout

* ci: don't run tests on travis at all

* style(fixes)

* fix(add tests)

* fix(recent_signer bug)

* fix(complete all tests)

* fix(nits)

* fix(simplify asserts)

* fix(cliqueState): simplify code

* fix(nits)

* docs(comments what's need to fixed)

* fix(revert unintended changes)

* fix(tests)

* fix(logs): voting logs

* fix(readability + more logs)

* fix(sync)

* docs(add missing licens header)

* fix(log): info! -> trace!

* docs(fix nits) + fix(remove assert)

* perf(use counter instead of vec)

* fix(remove needless block in match)

* fix(faulty comment)

* grumbles(docs for tests)

* fix(nits)

* fix(revert_vote): only remove vote when votes == 0

* fix(vote counter): checked arithmetics

* fix(simplify tests)

* fix(nits)

* fix(clique): err types

* fix(clique utils): make use of errors

* fix(cleanup nits)

* fix(clique sealing): don't read state no signer

* fix(replace Vec<Signers> with BTreeSet<Signers>)

* fix(tests): BTreeSet and more generic helpers

* fix(nits)

* fix(ethcore_block_seal): remove needless `Box`

* fix(faulty log): info -> trace

* fix(checked SystemTime): prevent SystemTime panics

* style(chain cfg): space after `:`

* style(fn enact): fix whitespace

* docs(clique): StepService

* docs(nit): fix faulty comment

* docs(fix typo)

* style(fix bad indentation)

* fix(bad regex match)

* grumble(on_seal_block): make `&mut` to avoid clone

* docs(on_seal_block): fix faulty documentation

* Delete .travis.yml

* docs: remove eth hf references in spec

* Update client.rs

* fix(nits)

* fix(clique step): `RwLock` -> `AtomicBool`

* fix(clique): use `Duration::as_millis`

* Clean up some Clique documentation
soc1c added a commit that referenced this pull request Mar 27, 2019
* fix broken sync

* correct seal fields

* ethcore: fix comment

* parity: remove duplicate params

* clique: fix whitespaces

* ethcore: fix goerli chain spec

* refactor signer_snapshot into pending/finalized state

* move close_block_extra_data after seal is applied

* refactor most of the logic into the signer_snapshot

* clique: refactor locking logic out of the consensus engine interface

* Fix jsonspec and add an unittest

* Replace space with tabs

* Unbroke sync

* Fix broken sync

* 1/2 state tracking without votes

* 2/2 implement vote tracking

* ci: use travis for goerli

* ci: setup a clique network

* ci: sync a görli node

* add clique deploy script

* ci: fix paths in clique deploy script

* ci: use docker compose

* ci: fix travis job names

* ci: fix build deps

* ci: massively reduce tests

* Revert "ci: massively reduce tests"

This reverts commit 6369f0b.

* ci: run cargo test directly

* ci: separate build and test stages

* ci: cache rust installation

* ci: simplify ci stages

* ci: make clique deploy script executable

* ci: shutdown goerli sync after 20min

* ci: remove slow sync stage

* ci: use timeout to finish jobs

* ci: fix build path

* ci: use absolute paths to end this confusion

* ci: add geth and parity to path

* ci: be more verbose

* ci: allow for more relaxed caching timeout

* ci: update repositories for custom ppa

* ci: fix typo in file name

* ci: fix docker compose file

* ci: add ethkey to docker

* ci: make sure deploy script is up to date with upstream

* ci: stop docker container after certain time

* ci: force superuser to update permissions on docker files

* ci: reduce run time of script to ~30 min

* ci: remove duplicate caching in travis

* remove trace statements

* clique: add more validation involving the recent signer list

* ethcore: enable constantinople for rinkeby

* ethcore: fix whitespaces in rinkeby spec

* ethcore: reformat goerli.json

* Revert "ci: remove duplicate caching in travis"

This reverts commit a562838.

* tmp commit

* another tmp commit

* it builds!

* add sealing capabilities

* add seal_header hook to allow separation of block seal/importing code paths

* clique: remove populate_from_parent.

* add panic

* make turn delay random

* initialize OpenBlock properly in 'enact'

* misc: remove duplicate lines

* misc: fix license headers

* misc: convert spaces to tabs

* misc: fix tabs

* Update Cargo.toml

* Update Cargo.toml

* Update Cargo.toml

* clique: ensure validator restores state before trying to seal

* clique: make 'state' return an Error.  Make some error messages more clear

* Fix compile error after rebase & toolchain upgrade

* fix a bunch of import warnings

* Refactor code

* Fix permissions

* Refactoring syncing

* Implement full validator checks

* Refactor util functions to seperate file

* mining 1

* ethcore: add chainspec for kotti

* ethcore: rename pre-goerli configs

* ethcore: load kotti chain spec

* cli: add kotti to params

* Implement working local sealing

* making sealing & syncing work together

* Relax timestamp checking

* ethcore: prepare for the real goerli to launch

* Implement NOTURN wiggle properly & cleanupnup warnings

* Implement vote casting

* Update docs & skip signing if no signer

* Optimize step-service interval

* Record state on local sealed block

* Fix script filemode

* Cleaning up codebase

* restore enact trace logging

* Delete clique.sh and move sync.sh

* remove travis.yml

* Remove dead code

* Cleanup compile warning

* address review comments

* adding more comments and removing unwrap()

* ci: remove sync script

* Address review comments

* fix compile error

* adding better debugging for timing

* Implement an dedicated thread for sealing timing

* fix(add helper for timestamp overflows) (#10330)

* fix(add helper timestamp overflows)

* fix(simplify code)

* fix(make helper private)

* snap: official image / test (#10168)

* official image / test

* fix / test

* bit more necromancy

* fix paths

* add source bin/df /test

* add source bin/df /test2

* something w paths /test

* something w paths /test

* add source-type /test

* show paths /test

* copy plugin /test

* plugin -> nil

* install rhash

* no questions while installing rhash

* publish snap only for release

* fix(docker): fix not receives SIGINT (#10059)

* fix(docker): fix not receives SIGINT

* fix: update with reviews

* update with review

* update

* update

* Don't add discovery initiators to the node table (#10305)

* Don't add discovery initiators to the node table

* Use enums for tracking state of the nodes in discovery

* Dont try to ping ourselves

* Fix minor nits

* Update timeouts when observing an outdated node

* Extracted update_bucket_record from update_node

* Fixed typo

* Fix two final nits from @todr

* change docker image based on debian instead of ubuntu due to the chan… (#10336)

* change docker image based on debian instead of ubuntu due to the changes of the build container

* role back docker build image and docker deploy image to ubuntu:xenial based (#10338)

* Bundle protocol and packet_id together in chain sync (#10315)

Define a new `enum` where devp2p subprotocol packet ids (currently eth and par) are defined. Additionally provide functionality to query id value and protocol of a given id object.

* snap: prefix version and populate candidate channel (#10343)

* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*

* addressing review comments

* engine: fix copyright header

* scripts: restore permissions on sign command

* ethcore: enforce tabs

* ethcore: enforce tabs

* ethcore: enforce tabs

* addressing comments

* addressing comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* json-spec: fix clique epoch to non-zero u64

* ci: enable travis for parity goerli

* ci: don't separate build and test step

* ci: don't run c++ tests on travis

* ci: simplify cargo test to squeeze into travis timeout

* ci: don't run tests on travis at all

* style(fixes)

* fix(add tests)

* fix(recent_signer bug)

* fix(complete all tests)

* fix(nits)

* fix(simplify asserts)

* fix(cliqueState): simplify code

* fix(nits)

* docs(comments what's need to fixed)

* fix(revert unintended changes)

* fix(tests)

* fix(logs): voting logs

* fix(readability + more logs)

* fix(sync)

* docs(add missing licens header)

* fix(log): info! -> trace!

* docs(fix nits) + fix(remove assert)

* perf(use counter instead of vec)

* fix(remove needless block in match)

* fix(faulty comment)

* grumbles(docs for tests)

* fix(nits)

* fix(revert_vote): only remove vote when votes == 0

* fix(vote counter): checked arithmetics

* fix(simplify tests)

* fix(nits)

* fix(clique): err types

* fix(clique utils): make use of errors

* fix(cleanup nits)

* fix(clique sealing): don't read state no signer

* fix(replace Vec<Signers> with BTreeSet<Signers>)

* fix(tests): BTreeSet and more generic helpers

* fix(nits)

* fix(ethcore_block_seal): remove needless `Box`

* fix(faulty log): info -> trace

* fix(checked SystemTime): prevent SystemTime panics

* style(chain cfg): space after `:`

* style(fn enact): fix whitespace

* docs(clique): StepService

* docs(nit): fix faulty comment

* docs(fix typo)

* style(fix bad indentation)

* fix(bad regex match)

* grumble(on_seal_block): make `&mut` to avoid clone

* docs(on_seal_block): fix faulty documentation

* Delete .travis.yml

* docs: remove eth hf references in spec

* Update client.rs

* fix(nits)

* fix(clique step): `RwLock` -> `AtomicBool`

* fix(clique): use `Duration::as_millis`

* Clean up some Clique documentation

Co-authored-by: soc1c <soc1c@users.noreply.github.com>
Co-authored-by: HCastano <HCastano@users.noreply.github.com>
Co-authored-by: niklasad1 <niklasad1@users.noreply.github.com>
Co-authored-by: jwasinger <jwasinger@users.noreply.github.com>
Co-authored-by: ChainSafe <ChainSafe@users.noreply.github.com>
Co-authored-by: thefallentree <thefallentree@users.noreply.github.com>
Co-authored-by: 5chdn <5chdn@users.noreply.github.com>
soc1c pushed a commit that referenced this pull request Mar 27, 2019
#10514)

* ethcore: add clique engine (#9981)

* fix broken sync

* correct seal fields

* ethcore: fix comment

* parity: remove duplicate params

* clique: fix whitespaces

* ethcore: fix goerli chain spec

* refactor signer_snapshot into pending/finalized state

* move close_block_extra_data after seal is applied

* refactor most of the logic into the signer_snapshot

* clique: refactor locking logic out of the consensus engine interface

* Fix jsonspec and add an unittest

* Replace space with tabs

* Unbroke sync

* Fix broken sync

* 1/2 state tracking without votes

* 2/2 implement vote tracking

* ci: use travis for goerli

* ci: setup a clique network

* ci: sync a görli node

* add clique deploy script

* ci: fix paths in clique deploy script

* ci: use docker compose

* ci: fix travis job names

* ci: fix build deps

* ci: massively reduce tests

* Revert "ci: massively reduce tests"

This reverts commit 6369f0b.

* ci: run cargo test directly

* ci: separate build and test stages

* ci: cache rust installation

* ci: simplify ci stages

* ci: make clique deploy script executable

* ci: shutdown goerli sync after 20min

* ci: remove slow sync stage

* ci: use timeout to finish jobs

* ci: fix build path

* ci: use absolute paths to end this confusion

* ci: add geth and parity to path

* ci: be more verbose

* ci: allow for more relaxed caching timeout

* ci: update repositories for custom ppa

* ci: fix typo in file name

* ci: fix docker compose file

* ci: add ethkey to docker

* ci: make sure deploy script is up to date with upstream

* ci: stop docker container after certain time

* ci: force superuser to update permissions on docker files

* ci: reduce run time of script to ~30 min

* ci: remove duplicate caching in travis

* remove trace statements

* clique: add more validation involving the recent signer list

* ethcore: enable constantinople for rinkeby

* ethcore: fix whitespaces in rinkeby spec

* ethcore: reformat goerli.json

* Revert "ci: remove duplicate caching in travis"

This reverts commit a562838.

* tmp commit

* another tmp commit

* it builds!

* add sealing capabilities

* add seal_header hook to allow separation of block seal/importing code paths

* clique: remove populate_from_parent.

* add panic

* make turn delay random

* initialize OpenBlock properly in 'enact'

* misc: remove duplicate lines

* misc: fix license headers

* misc: convert spaces to tabs

* misc: fix tabs

* Update Cargo.toml

* Update Cargo.toml

* Update Cargo.toml

* clique: ensure validator restores state before trying to seal

* clique: make 'state' return an Error.  Make some error messages more clear

* Fix compile error after rebase & toolchain upgrade

* fix a bunch of import warnings

* Refactor code

* Fix permissions

* Refactoring syncing

* Implement full validator checks

* Refactor util functions to seperate file

* mining 1

* ethcore: add chainspec for kotti

* ethcore: rename pre-goerli configs

* ethcore: load kotti chain spec

* cli: add kotti to params

* Implement working local sealing

* making sealing & syncing work together

* Relax timestamp checking

* ethcore: prepare for the real goerli to launch

* Implement NOTURN wiggle properly & cleanupnup warnings

* Implement vote casting

* Update docs & skip signing if no signer

* Optimize step-service interval

* Record state on local sealed block

* Fix script filemode

* Cleaning up codebase

* restore enact trace logging

* Delete clique.sh and move sync.sh

* remove travis.yml

* Remove dead code

* Cleanup compile warning

* address review comments

* adding more comments and removing unwrap()

* ci: remove sync script

* Address review comments

* fix compile error

* adding better debugging for timing

* Implement an dedicated thread for sealing timing

* fix(add helper for timestamp overflows) (#10330)

* fix(add helper timestamp overflows)

* fix(simplify code)

* fix(make helper private)

* snap: official image / test (#10168)

* official image / test

* fix / test

* bit more necromancy

* fix paths

* add source bin/df /test

* add source bin/df /test2

* something w paths /test

* something w paths /test

* add source-type /test

* show paths /test

* copy plugin /test

* plugin -> nil

* install rhash

* no questions while installing rhash

* publish snap only for release

* fix(docker): fix not receives SIGINT (#10059)

* fix(docker): fix not receives SIGINT

* fix: update with reviews

* update with review

* update

* update

* Don't add discovery initiators to the node table (#10305)

* Don't add discovery initiators to the node table

* Use enums for tracking state of the nodes in discovery

* Dont try to ping ourselves

* Fix minor nits

* Update timeouts when observing an outdated node

* Extracted update_bucket_record from update_node

* Fixed typo

* Fix two final nits from @todr

* change docker image based on debian instead of ubuntu due to the chan… (#10336)

* change docker image based on debian instead of ubuntu due to the changes of the build container

* role back docker build image and docker deploy image to ubuntu:xenial based (#10338)

* Bundle protocol and packet_id together in chain sync (#10315)

Define a new `enum` where devp2p subprotocol packet ids (currently eth and par) are defined. Additionally provide functionality to query id value and protocol of a given id object.

* snap: prefix version and populate candidate channel (#10343)

* snap: populate candidate releases with beta snaps to avoid stale channel

* snap: prefix version with v*

* addressing review comments

* engine: fix copyright header

* scripts: restore permissions on sign command

* ethcore: enforce tabs

* ethcore: enforce tabs

* ethcore: enforce tabs

* addressing comments

* addressing comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* addressing more comments

* json-spec: fix clique epoch to non-zero u64

* ci: enable travis for parity goerli

* ci: don't separate build and test step

* ci: don't run c++ tests on travis

* ci: simplify cargo test to squeeze into travis timeout

* ci: don't run tests on travis at all

* style(fixes)

* fix(add tests)

* fix(recent_signer bug)

* fix(complete all tests)

* fix(nits)

* fix(simplify asserts)

* fix(cliqueState): simplify code

* fix(nits)

* docs(comments what's need to fixed)

* fix(revert unintended changes)

* fix(tests)

* fix(logs): voting logs

* fix(readability + more logs)

* fix(sync)

* docs(add missing licens header)

* fix(log): info! -> trace!

* docs(fix nits) + fix(remove assert)

* perf(use counter instead of vec)

* fix(remove needless block in match)

* fix(faulty comment)

* grumbles(docs for tests)

* fix(nits)

* fix(revert_vote): only remove vote when votes == 0

* fix(vote counter): checked arithmetics

* fix(simplify tests)

* fix(nits)

* fix(clique): err types

* fix(clique utils): make use of errors

* fix(cleanup nits)

* fix(clique sealing): don't read state no signer

* fix(replace Vec<Signers> with BTreeSet<Signers>)

* fix(tests): BTreeSet and more generic helpers

* fix(nits)

* fix(ethcore_block_seal): remove needless `Box`

* fix(faulty log): info -> trace

* fix(checked SystemTime): prevent SystemTime panics

* style(chain cfg): space after `:`

* style(fn enact): fix whitespace

* docs(clique): StepService

* docs(nit): fix faulty comment

* docs(fix typo)

* style(fix bad indentation)

* fix(bad regex match)

* grumble(on_seal_block): make `&mut` to avoid clone

* docs(on_seal_block): fix faulty documentation

* Delete .travis.yml

* docs: remove eth hf references in spec

* Update client.rs

* fix(nits)

* fix(clique step): `RwLock` -> `AtomicBool`

* fix(clique): use `Duration::as_millis`

* Clean up some Clique documentation

* Add trace information to eth_estimateGas (#10519)

* Add trace information to eth_estimateGas

* replace unwrap better version

* change vm::Error formatter to more user-friendly

* remove extra error format

* use map_or instead sequence of map/unwrap_or

* fix(light/on_demand): extract as a trait

* fix(grumble): OnDemand remove needless trait bound
ordian added a commit that referenced this pull request Apr 5, 2019
* master:
  no volumes are needed, just run -v volume:/path/in/the/container (#10345)
  Fixed misstype (#10351)
  snap: prefix version and populate candidate channel (#10343)
  Bundle protocol and packet_id together in chain sync (#10315)
  role back docker build image and docker deploy image to ubuntu:xenial based (#10338)
  change docker image based on debian instead of ubuntu due to the chan… (#10336)
  Don't add discovery initiators to the node table (#10305)
  fix(docker): fix not receives SIGINT (#10059)
  snap: official image / test (#10168)
  fix(add helper for timestamp overflows) (#10330)
  Additional error for invalid gas (#10327)
  Revive parity_setMinGasPrice RPC call (#10294)
  Add Statetest support for Constantinople Fix (#10323)
  fix(parity-clib): grumbles that were not addressed in #9920 (#10154)
  fix(light-rpc): Make `light_sync` generic (#10238)
  fix publish job (#10317)
  Secure WS-RPC: grant access to all apis (#10246)
  Make specification of protocol in SyncRequester::send_request explicit (#10295)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants