Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

CI improvements #10579

Merged
merged 29 commits into from
Apr 12, 2019
Merged

CI improvements #10579

merged 29 commits into from
Apr 12, 2019

Conversation

TriplEight
Copy link
Collaborator

@TriplEight TriplEight commented Apr 8, 2019 •
edited
Loading

  • Rust nightly and beta tests are back and shiny, will run during the nightly build
  • all test and build jobs changed to run with --verbose --color=always
  • max cache size raised to 50 Gib
  • log files are collected for linux jobs and uploaded to GitLab artifacts. But I didn't figure out how to have two artifacts: sections in one job, so for build stage logs will still be uploaded, but with the &collect_artifacts rule (on_success and 1 mos).

So I was testing pipelines with per-job sccache caching, thinking it was a last resort.
It turned out it was not necessary to resort to such extreme measures:
Random compilation failure bug seems to appear only when the max cache size allocated is exceeded, and fail happens when one job removes an arbitrary artifact and then the next job wants to remove the same one, but doesn't find it.

Another problem I thought was connected with caching, some tests were failing. At first I thought it's due to caching, but per-job isolation showed that it's not the caching problem.

As a bonus, we (with Niklas help) have found 2 flaky tests.

@parity-cla-bot
Copy link

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@TriplEight TriplEight added the M1-ci 🙉 Continuous integration. label Apr 8, 2019
@TriplEight TriplEight changed the title WIP: random CI runner problems. WIP: CI improvements Apr 8, 2019
@General-Beck General-Beck self-requested a review April 11, 2019 13:23
@TriplEight TriplEight changed the title WIP: CI improvements CI improvements Apr 11, 2019
@TriplEight TriplEight requested a review from gabreal April 11, 2019 19:49
gabreal
gabreal approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks also good to me. so there won't be tests for mac or win?

.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@TriplEight
Copy link
Collaborator Author

looks also good to me. so there won't be tests for mac or win?

@gabreal this is not decided yet, and will require changes on hosts.

@TriplEight TriplEight merged commit 6fcd775 into master Apr 12, 2019
@General-Beck General-Beck deleted the runner_fix branch April 13, 2019 19:00
ordian added a commit that referenced this pull request Apr 15, 2019
@ordian
Merge branch 'master' into ao-lmdb
7a12b3f 
* master:
  CI improvements (#10579)
  Watch transactions pool (#10558)
  fix(evmbin): make benches compile again (#10586)
  fix issue with compilation when 'slow-blocks' feature enabled (#10585)
  Reject crazy timestamps instead of truncating. (#10574)
  Node table limiting and cache for node filter (#10288)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabreal gabreal gabreal approved these changes

@General-Beck General-Beck General-Beck approved these changes

Assignees
No one assigned
Labels
M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TriplEight @parity-cla-bot @General-Beck @gabreal