Update publishing #10644

TriplEight · 2019-05-10T11:38:46Z

removed the listing of sccache debug log
docker images with parity-ethereum is now being built by k8s
Dockerfile was optimized and lost openssl
for now, there are docker tags and docker pushes for the all cases possible, to be decided later which do we need
publishing of the docker image should not run nightly
stopped onchain updates for Kovan
new artifacts dir for scripts: tools
-- less jobs require git clone and submodules
show rust version for docker builds

Tests are OK, but I'm afraid publish-snap and publish-onchain can break.

parity-cla-bot · 2019-05-10T11:38:49Z

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

.gitlab-ci.yml

scripts/docker/hub/Dockerfile

.gitlab-ci.yml

gabreal · 2019-05-27T13:11:57Z

scripts/docker/hub/entrypoint.sh

+echo "everywhere would be safe."
+echo "#################################################################################"
+
+/bin/parity $@


the entrypoint.sh was obsoleted before, why bring it back?
--- and if wasn't it exec /bin/parity $@ to make parity the main process of the image?

Why is the image now called ethereum instead of parity-ethereum like the repository?

Concerning my first comment, afair the entrypoint script was introduced to have a variable binary. Like this there is really no benefit.

just to send this deprecation message

thanks, I'll check it then

we decided with @kirushik that why not, it's still in Parity's repo, which makes it parity/ethereum

since COPY instruction in the Dockerfile copies the concrete file, $@ just take the arguments. Is there a way to do it better?

That's the original entrypoint.sh:
v2.3.7...master#diff-c346274d88c3013298b1e18cbb88a149

ah, you were asking for a better way of printing this message. well then still you can use exec.

* we decided with @kirushik that why not, it's still in Parity's repo, which makes it `parity/ethereum`

so the repository parity/parity was renamed to parity/parity-ethereum because that was the new name of the software. what is the reason not to do the same for the docker repo?

fixed and simplified, thanks.

It was made to be more clear. ethereum instead of parity-ethereum is only because it stays in parity docker namespace.
It will be better than parity/parity since we are going to publish more clients there: bitcoin, zcash and whatnot.

scripts/docker/hub/publish-docker.sh

scripts/docker/hub/parity.Dockerfile

* master: introduce MissingParent Error, fixes #10699 (#10700) Update publishing (#10644)

* docker images are now built on k8s: test run * copy check_sync.sh in build-linux job * copy scripts/docker/hub/* in build-linux job * removed cache var * cleanup, no more nightly dockers * cleanup in dockerfile * some new tags * removed sccsche debug log, cleanup * no_gits, new artifacts dir, changed scripts. Test run. * define version once * one source for TRACK * stop kovan onchain updates * moved changes for two images to a new branch * rename Dockerfile * no need in libudev-dev

* version: bump stable to 2.4.7 * [CI] allow cargo audit to fail (#10676) * [CI] allow cargo audit to fail * [.gitlab-ci.yml] add a comment about cargo audit * [Cargo.lock] cargo update -p protobuf * new image (#10673) * Update publishing (#10644) * docker images are now built on k8s: test run * copy check_sync.sh in build-linux job * copy scripts/docker/hub/* in build-linux job * removed cache var * cleanup, no more nightly dockers * cleanup in dockerfile * some new tags * removed sccsche debug log, cleanup * no_gits, new artifacts dir, changed scripts. Test run. * define version once * one source for TRACK * stop kovan onchain updates * moved changes for two images to a new branch * rename Dockerfile * no need in libudev-dev * enable lto for release builds (#10717) * Use RUSTFLAGS to set the optimization level (#10719) * Use RUSTFLAGS to set the optimization level Cargo has a [quirk]() in how configuration settings are propagated when `cargo test` runs: local code respect the settings in `[profile.test]` but all dependencies use the `[profile.dev]` settings. Here we force `opt-level=3` for all dependencies. * Remove unused profile settings * Maybe like this? * Turn off incremental compilation * Remove colors; try again with overflow-checks on * Use quiet CI machine * Turn overflow checking back on * Be explicit about what options we use * Remove "quiet machine" override * ethcore: enable ECIP-1054 for classic (#10731) * config: enable atlantis on ethereum classic * config: enable atlantis on morden classic * config: enable atlantis on morden classic * config: enable atlantis on kotti classic * ethcore: move kotti fork block to 0xAEF49 * ethcore: move morden fork block to 0x4829BA * ethcore: move classic fork block to 0x81B320 * remove trailing comma * remove trailing comma * fix chainspec * ethcore: move classic fork block to 0x7fffffffffffffff

* version: bump beta to 2.5.2 * [CI] allow cargo audit to fail (#10676) * [CI] allow cargo audit to fail * [.gitlab-ci.yml] add a comment about cargo audit * [Cargo.lock] cargo update -p protobuf * Reset blockchain properly (#10669) * delete BlockDetails from COL_EXTRA * better proofs * added tests * PR suggestions * new image (#10673) * Update publishing (#10644) * docker images are now built on k8s: test run * copy check_sync.sh in build-linux job * copy scripts/docker/hub/* in build-linux job * removed cache var * cleanup, no more nightly dockers * cleanup in dockerfile * some new tags * removed sccsche debug log, cleanup * no_gits, new artifacts dir, changed scripts. Test run. * define version once * one source for TRACK * stop kovan onchain updates * moved changes for two images to a new branch * rename Dockerfile * no need in libudev-dev * enable lto for release builds (#10717) * Use RUSTFLAGS to set the optimization level (#10719) * Use RUSTFLAGS to set the optimization level Cargo has a [quirk]() in how configuration settings are propagated when `cargo test` runs: local code respect the settings in `[profile.test]` but all dependencies use the `[profile.dev]` settings. Here we force `opt-level=3` for all dependencies. * Remove unused profile settings * Maybe like this? * Turn off incremental compilation * Remove colors; try again with overflow-checks on * Use quiet CI machine * Turn overflow checking back on * Be explicit about what options we use * Remove "quiet machine" override * ethcore: enable ECIP-1054 for classic (#10731) * config: enable atlantis on ethereum classic * config: enable atlantis on morden classic * config: enable atlantis on morden classic * config: enable atlantis on kotti classic * ethcore: move kotti fork block to 0xAEF49 * ethcore: move morden fork block to 0x4829BA * ethcore: move classic fork block to 0x81B320 * remove trailing comma * remove trailing comma * fix chainspec * ethcore: move classic fork block to 0x7fffffffffffffff

docker images are now built on k8s: test run

bd85eb1

TriplEight added the M1-ci 🙉 Continuous integration. label May 10, 2019

TriplEight changed the title ~~docker images are now built on k8s: test run~~ build docker images with k8s May 10, 2019

TriplEight added 3 commits May 10, 2019 14:02

fix lint

da98e8a

weird var check

33c9974

copy check_sync.sh in build-linux job

6832077

TriplEight changed the title ~~build docker images with k8s~~ WIP: build docker images with k8s May 13, 2019

TriplEight added 5 commits May 13, 2019 13:03

copy scripts/docker/hub/* in build-linux job

2cf87f3

removed cache var

87d652e

right Dockerfile path

c9030b8

docker push goes w/o --tag

e7868f3

cleanup, no more nightly dockers

a78e014

TriplEight commented May 13, 2019

View reviewed changes

.gitlab-ci.yml Outdated Show resolved Hide resolved

.gitlab-ci.yml Outdated Show resolved Hide resolved

.gitlab-ci.yml Outdated Show resolved Hide resolved

.gitlab-ci.yml Outdated Show resolved Hide resolved

TriplEight requested a review from gabreal May 13, 2019 15:17

TriplEight added the A0-pleasereview 🤓 Pull request needs code review. label May 13, 2019

cleanup in dockerfile

eb79575

gabreal reviewed May 13, 2019

View reviewed changes

TriplEight added 12 commits May 13, 2019 22:31

review 1

76b8bc1

lint error

1b2cd2e

test run

ff3a246

test run 2

5514b28

test run 3

3309ece

test run 4

5e983df

test run 5

bee54e1

test run 6

cea18d4

test run 7

e91c409

some new tags

714b9b2

fix tags

2022556

fix tags 2

655617d

variable tag in parity

bee3316

TriplEight force-pushed the build_docker_on_k8s branch from dbbcb4c to d51712a Compare May 22, 2019 17:18

Triggering Gitlab sync

1e3c749

TriplEight force-pushed the build_docker_on_k8s branch from d51712a to 1e3c749 Compare May 22, 2019 17:21

TriplEight added 3 commits May 22, 2019 20:00

deprecated warning

567d851

cleanup

576e977

Merge remote-tracking branch 'origin/master' into build_docker_on_k8s

063736e

TriplEight changed the title ~~WIP: build docker images with k8s~~ build docker images with k8s May 23, 2019

TriplEight changed the title ~~build docker images with k8s~~ Update publishing May 23, 2019

TriplEight requested a review from kirushik May 23, 2019 17:50

TriplEight added A8-backport 🕸 Pull request is already reviewed well in another branch. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. B1-patch-beta 🕷🕷 labels May 23, 2019

rust versions

e1f8bf6

General-Beck approved these changes May 27, 2019

View reviewed changes

gabreal reviewed May 27, 2019

View reviewed changes

kirushik approved these changes May 27, 2019

View reviewed changes

scripts/docker/hub/parity.Dockerfile Outdated Show resolved Hide resolved

TriplEight added 4 commits May 28, 2019 11:14

review. Optimized Dockerfile

0c88690

moved changes for two images to a new branch

f5e7603

rename Dockerfile

70e1570

no need in libudev-dev

802d88c

TriplEight merged commit 7e89bab into master May 31, 2019

General-Beck deleted the build_docker_on_k8s branch June 3, 2019 10:22

ordian added a commit that referenced this pull request Jun 3, 2019

Merge branch 'master' into ao-upgrade-ethereum-types

94db3a0

* master: introduce MissingParent Error, fixes #10699 (#10700) Update publishing (#10644)

This was referenced Jun 11, 2019

backports for stable 2.4.7 #10736

Merged

backports for beta 2.5.2 #10737

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update publishing #10644

Update publishing #10644

TriplEight commented May 10, 2019 •

edited

Loading

parity-cla-bot commented May 10, 2019

gabreal May 27, 2019

gabreal May 27, 2019

gabreal May 27, 2019

TriplEight May 27, 2019

gabreal May 28, 2019

gabreal May 28, 2019

gabreal May 28, 2019 •

edited

Loading

TriplEight May 28, 2019

TriplEight May 28, 2019 •

edited

Loading

Update publishing #10644

Update publishing #10644

Conversation

TriplEight commented May 10, 2019 • edited Loading

parity-cla-bot commented May 10, 2019

gabreal May 27, 2019

Choose a reason for hiding this comment

gabreal May 27, 2019

Choose a reason for hiding this comment

gabreal May 27, 2019

Choose a reason for hiding this comment

TriplEight May 27, 2019

Choose a reason for hiding this comment

gabreal May 28, 2019

Choose a reason for hiding this comment

gabreal May 28, 2019

Choose a reason for hiding this comment

gabreal May 28, 2019 • edited Loading

Choose a reason for hiding this comment

TriplEight May 28, 2019

Choose a reason for hiding this comment

TriplEight May 28, 2019 • edited Loading

Choose a reason for hiding this comment

TriplEight commented May 10, 2019 •

edited

Loading

gabreal May 28, 2019 •

edited

Loading

TriplEight May 28, 2019 •

edited

Loading