Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Log validator set changes in EpochManager #10734

Merged
merged 36 commits into from
Jun 25, 2019
Merged

Log validator set changes in EpochManager #10734

merged 36 commits into from
Jun 25, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jun 10, 2019 •
edited
Loading

Builds on #10733

ref. #10085

HCastano and others added 19 commits June 10, 2019 12:26
@HCastano @dvdplm
Stop breaking out of loop if a non-canonical hash is found
4050074
@dvdplm
include expected hash in log msg
88bafbe
@dvdplm
More logging
fd2a19f
@dvdplm
Scope
704463d
@dvdplm
Syntax
5f9caa5
@dvdplm
Log in blank RollingFinality
befe9b8 
Escalate bad proposer to warning
@dvdplm
Check validator set size: warn if 1 or even number
1b7acd0
@dvdplm
More readable code
4afc40b
@dvdplm
Merge branch 'dp/hc-non-canon-block-logging' into dp/chore/aura-warn-…
1ed6505 
…when-validators-is-1-or-even

* dp/hc-non-canon-block-logging:
  More readable code
@dvdplm
Use SimpleList::new
c77e8da
@dvdplm
Extensive logging on unexpected non-canonical hash
b680026
@dvdplm
Wording
2551e0f
@dvdplm
Merge branch 'dp/hc-non-canon-block-logging' into dp/chore/aura-warn-…
06c0ba4 
…when-validators-is-1-or-even

* dp/hc-non-canon-block-logging:
  Wording
  Extensive logging on unexpected non-canonical hash
@dvdplm
wip
8ed48b4
@dvdplm @tomusdrw
Update ethcore/blockchain/src/blockchain.rs
ffbfdac 
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@dvdplm
Improved logging, address grumbles
b257e5e
@dvdplm
Merge branch 'dp/chore/aura-warn-when-validators-is-1-or-even' of git…
b5743b8 
…hub.com:paritytech/parity-ethereum into dp/chore/aura-warn-when-validators-is-1-or-even

* 'dp/chore/aura-warn-when-validators-is-1-or-even' of github.com:paritytech/parity-ethereum:
  Update ethcore/blockchain/src/blockchain.rs
@dvdplm
Merge branch 'master' into dp/chore/aura-warn-when-validators-is-1-or…
070e585 
…-even

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
@dvdplm
Merge branch 'master' into dp/chore/aura-log-validator-set-in-epoch-m…
4f00ac7 
…anager

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
@dvdplm dvdplm self-assigned this Jun 10, 2019
@dvdplm dvdplm added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Jun 10, 2019
@dvdplm
Merge branch 'dp/chore/aura-warn-when-validators-is-1-or-even' into d…
d338411 
…p/chore/aura-log-validator-set-in-epoch-manager

* dp/chore/aura-warn-when-validators-is-1-or-even:
  Improved logging, address grumbles
  Update ethcore/blockchain/src/blockchain.rs
@dvdplm dvdplm changed the title Thank you for your Pull Request! Log validator set changes in EpochManager Jun 10, 2019
dvdplm and others added 3 commits June 11, 2019 06:34
@dvdplm @ltfschoen
Update ethcore/src/engines/validator_set/simple_list.rs
0edf27e 
Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>
@dvdplm
Report benign misbehaviour iff currently a validator
b32d632
@dvdplm
Merge branch 'dp/chore/aura-log-validator-set-in-epoch-manager' of gi…
b62d11f 
…thub.com:paritytech/parity-ethereum into dp/chore/aura-log-validator-set-in-epoch-manager

* 'dp/chore/aura-log-validator-set-in-epoch-manager' of github.com:paritytech/parity-ethereum:
  Update ethcore/src/engines/validator_set/simple_list.rs
@dvdplm
Test reporting behaviour
d09fea8 
Don't require node to be part of the validator set to report malicious behaviour
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jun 11, 2019
@dvdplm dvdplm mentioned this pull request Jun 13, 2019
Merged
@dvdplm
Merge branch 'master' into dp/chore/aura-warn-when-validators-is-1-or…
5dff9e1 
…-even

* master:
  [devp2p] Update to 2018 edition (#10716)
  Add a way to signal shutdown to snapshotting threads (#10744)
  Enable aesni (#10756)
  remove support of old SS db formats (#10757)
  [devp2p] Don't use `rust-crypto` (#10714)
  updater: fix static id hashes initialization (#10755)
  Use fewer threads for snapshotting (#10752)
  Die error_chain, die (#10747)
  Fix deprectation warnings on nightly (#10746)
  fix docker tags for publishing (#10741)
  DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705)
  ethcore: enable ECIP-1054 for classic (#10731)
@dvdplm
Merge branch 'dp/chore/aura-warn-when-validators-is-1-or-even' into d…
ded29d8 
…p/chore/aura-log-validator-set-in-epoch-manager

* dp/chore/aura-warn-when-validators-is-1-or-even:
  [devp2p] Update to 2018 edition (#10716)
  Add a way to signal shutdown to snapshotting threads (#10744)
  Enable aesni (#10756)
  remove support of old SS db formats (#10757)
  [devp2p] Don't use `rust-crypto` (#10714)
  updater: fix static id hashes initialization (#10755)
  Use fewer threads for snapshotting (#10752)
  Die error_chain, die (#10747)
  Fix deprectation warnings on nightly (#10746)
  fix docker tags for publishing (#10741)
  Update ethcore/src/engines/validator_set/simple_list.rs
  DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705)
  ethcore: enable ECIP-1054 for classic (#10731)
@dvdplm
Merge branch 'master' into dp/chore/aura-log-validator-set-in-epoch-m…
fbb5994 
…anager

* master:
  Print warnings when using dangerous settings for ValidatorSet (#10733)
  ethcore/res: activate atlantis classic hf on block 8772000 (#10766)
  refactor: Fix indentation (#10740)
  Updated Bn128PairingImpl to use optimized batch pairing  (#10765)
  fix: aura don't add `SystemTime::now()` (#10720)
  Initialize private tx logger only if private tx functionality is enabled (#10758)
  Remove unused code (#10762)
  Remove calls to heapsize (#10432)
@dvdplm
cleanup
1a304d3
@dvdplm dvdplm requested review from tomusdrw and ngotchac June 24, 2019 13:06
tomusdrw
tomusdrw approved these changes Jun 24, 2019
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some minor grumbles

ethcore/src/engines/authority_round/mod.rs Show resolved Hide resolved
ethcore/src/engines/authority_round/mod.rs Outdated Show resolved Hide resolved
ethcore/src/engines/authority_round/mod.rs Outdated Show resolved Hide resolved
@tomusdrw
Copy link
Collaborator

I just looked at the code and it seems there is some confusion about who can/should issue reports.
I believe the original intention of the code was to report on every node that has --engine-signer configured even though it's not part of the validator set and let the contract decide.

I'd split engine_signer into: block_signer & reporting_signer (doesn't need CLI flag initially, but just for code clarity) and then use appropriate signers for different things. So it means that we would allow reporting even if it's not part of the validator set.

@dvdplm
On second thought non-validators are allowed to report
1a0f82b
@dvdplm
cleanup
05df053
@dvdplm
Merge branch 'master' into dp/chore/aura-log-validator-set-in-epoch-m…
8a83bd8 
…anager

* master:
  Treat empty account the same as non-exist accounts in EIP-1052 (#10775)
  docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
  Move Engine::register_client to be before other I/O handler registration (#10767)
@dvdplm
remove dead code
9080630
@dvdplm dvdplm mentioned this pull request Jun 25, 2019
Closed
@dvdplm dvdplm merged commit 825c799 into master Jun 25, 2019
@dvdplm dvdplm deleted the dp/chore/aura-log-validator-set-in-epoch-manager branch June 25, 2019 11:15
dvdplm added a commit that referenced this pull request Jul 1, 2019
@dvdplm
Merge branch 'master' into dp/fix/prevent-building-block-on-top-of-sa…
7091403 
…me-parent

* master:
  Log validator set changes in EpochManager (#10734)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ltfschoen ltfschoen ltfschoen left review comments

@ngotchac ngotchac ngotchac approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees

@dvdplm dvdplm

Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dvdplm @tomusdrw @ngotchac @ltfschoen @HCastano