Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Improve logging when remote peer is unknown #10817

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Improve logging when remote peer is unknown #10817

merged 1 commit into from
Jul 4, 2019

Conversation

seunlanlege
Copy link
Member

This is a draft PR simply to enable investigation of #10781

@nathPay is it possible for your to test this branch with your Kubernetes set up?

@parity-cla-bot
Copy link

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@dvdplm dvdplm changed the title Parity Kubernetes Improve logging when remote peer is unknown Jul 1, 2019
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a draft, seems like a good first step.

@nathPay
Copy link

nathPay commented Jul 1, 2019

@seunlanlege I've built the docker image and run it uing kubernetes and it seems that it does not change anythings.

@dvdplm
Copy link
Collaborator

dvdplm commented Jul 1, 2019

@nathPay can you report back your logs with this branch please?

@nathPay
Copy link

nathPay commented Jul 1, 2019

@seunlanlege Here part of log with potential errors:

...
2019-07-01 11:54:41 UTC  TRACE network  connection deregister; token=0
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Read 32 of 32 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  Expect to read 208 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Read 64 of 208 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Read 128 of 208 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Read 208 of 208 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:41 UTC IO Worker #2 DEBUG network  Hello: Parity-Ethereum/v2.5.1-beta-adabd81-20190514/x86_64-linux-gnu/rustc1.34.1 v5 0x3155…6481 [SessionCapabilityInfo { protocol: [101, 116, 104], version: 63, packet_count: 17, id_offset: 16 }, SessionCapabilityInfo { protocol: [112, 97, 114], version: 3, packet_count: 24, id_offset: 33 }, SessionCapabilityInfo { protocol: [112, 105, 112], version: 1, packet_count: 9, id_offset: 57 }]
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  compressed 1 to 3
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Sending 64 bytes
2019-07-01 11:54:41 UTC  TRACE network  connection reregister; token=Token(5)
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  5: Wrote 64 bytes
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  compressed 329 to 290
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Sending 352 bytes
2019-07-01 11:54:41 UTC  TRACE network  connection reregister; token=Token(5)
2019-07-01 11:54:41 UTC  TRACE network  connection reregister; token=Token(5)
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  compressed 109 to 54
2019-07-01 11:54:41 UTC IO Worker #3 TRACE network  Hup: 5
2019-07-01 11:54:41 UTC IO Worker #3 TRACE network  Connection closed: 5
2019-07-01 11:54:41 UTC IO Worker #2 TRACE network  5: Sending 112 bytes
2019-07-01 11:54:41 UTC  TRACE network  connection reregister; token=Token(5)
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Hup: 5
2019-07-01 11:54:41 UTC  TRACE network  connection deregister; token=5
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Connection closed: 5
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Hup: 2
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Connection closed: 2
2019-07-01 11:54:41 UTC  TRACE network  connection deregister; token=2
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Hup: 9
2019-07-01 11:54:41 UTC IO Worker #0 TRACE network  Connection closed: 9
2019-07-01 11:54:41 UTC  TRACE network  connection deregister; token=9
2019-07-01 11:54:42 UTC IO Worker #3 TRACE network  Connection timeout: 15

...

2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  Connection closed: 18
2019-07-01 11:54:43 UTC  TRACE network  connection deregister; token=18
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Read 32 of 32 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Expect to read 208 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Read 64 of 208 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Read 128 of 208 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Read 208 of 208 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:43 UTC IO Worker #1 DEBUG network  Hello: Parity-Ethereum/v2.4.6-stable-94164e1ca-20190514/x86_64-linux-musl/rustc1.31.1 v5 0xd8b1…62b8 [SessionCapabilityInfo { protocol: [101, 116, 104], version: 63, packet_count: 17, id_offset: 16 }, SessionCapabilityInfo { protocol: [112, 97, 114], version: 3, packet_count: 24, id_offset: 33 }, SessionCapabilityInfo { protocol: [112, 105, 112], version: 1, packet_count: 9, id_offset: 57 }]
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  compressed 1 to 3
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Sending 64 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  0: Wrote 64 bytes
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  compressed 329 to 290
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Sending 352 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  compressed 109 to 54
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  0: Sending 112 bytes
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  0: Wrote 352 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  0: Wrote 112 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(0)
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Hup: 0
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Connection closed: 0
2019-07-01 11:54:43 UTC  TRACE network  connection deregister; token=0
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  9: Wrote 307 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(9)
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  2: Read 64 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  2: Read 128 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  2: Read 210 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  Received handshake ack from "134.209.192.170:30303"
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  2: Sending 240 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(2)
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(2)
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  2: Wrote 240 bytes
2019-07-01 11:54:43 UTC  TRACE network  connection reregister; token=Token(2)
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  5: Read 64 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  5: Read 128 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  5: Read 210 of 210 bytes
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  Received handshake ack from "18.202.221.230:30303"
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Hup: 5
2019-07-01 11:54:43 UTC IO Worker #1 TRACE network  Connection closed: 5
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:43 UTC IO Worker #2 TRACE network  5: Sending 240 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  5: Read 32 of 32 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  5: Read 32 of 32 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  Expect to read 32 bytes
2019-07-01 11:54:43 UTC IO Worker #0 TRACE network  Session read error: 5:Some(0xb02a0eb711ed1e5c2b5fa7212f0b33b30c403d3b58979d40ce836f9255490c2106172482dd8cbdf129c3ae6be6965ff5e4bf117680a60078ad55e98507e9e01e) (Ok(V4(18.202.221.230:30303))) Disconnect(TooManyPeers)
...

@seunlanlege seunlanlege marked this pull request as ready for review July 2, 2019 11:21
@dvdplm dvdplm added A8-looksgood 🦄 Pull request is reviewed well. A0-pleasereview 🤓 Pull request needs code review. labels Jul 4, 2019
@dvdplm dvdplm merged commit bbae075 into master Jul 4, 2019
@dvdplm dvdplm deleted the parity-kube branch July 4, 2019 12:59
dvdplm added a commit that referenced this pull request Jul 4, 2019
* master:
  Extricate PodAccount and state Account to own crates (#10838)
  logs (#10817)
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
dvdplm added a commit that referenced this pull request Jul 4, 2019
…hore/extricate-state-backend

* dp/chore/extricate-account-db-into-own-crate:
  third time's the charm
  test failure 2
  test failure
  Extricate PodAccount and state Account to own crates (#10838)
  logs (#10817)
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants