Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Extract AccountDB to account-db #10839

Merged
merged 10 commits into from
Jul 4, 2019
Merged

Extract AccountDB to account-db #10839

merged 10 commits into from
Jul 4, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jul 4, 2019

Builds on #10838

@dvdplm dvdplm self-assigned this Jul 4, 2019
@dvdplm dvdplm added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 4, 2019
@dvdplm dvdplm mentioned this pull request Jul 4, 2019
Merged
@ordian
Copy link
Collaborator

ordian commented Jul 4, 2019

Could you rebase on master?

@dvdplm
Merge branch 'master' into dp/chore/extricate-account-db-into-own-crate
b7c7aae 
* master:
  Extricate PodAccount and state Account to own crates (#10838)
  logs (#10817)
  refactor: whisper: Add type aliases and update rustdocs in message.rs (#10812)
  Break circular dependency between Client and Engine (part 1) (#10833)
  tests: Relates to #10655: Test instructions for Readme (#10835)
  refactor: Related #9459 - evmbin: replace untyped json! macro with fully typed serde serialization using Rust structs (#10657)
@dvdplm
Copy link
Collaborator Author

dvdplm commented Jul 4, 2019

Could you rebase on master?

Done.

@ordian
Copy link
Collaborator

ordian commented Jul 4, 2019 

error[E0583]: file not found for module `account_db`
   --> ethcore/src/lib.rs:173:9
    |
173 | pub mod account_db;

@ordian ordian added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 4, 2019
@ordian ordian added this to the 2.6 milestone Jul 4, 2019
@dvdplm dvdplm merged commit fafb534 into master Jul 4, 2019
@dvdplm dvdplm deleted the dp/chore/extricate-account-db-into-own-crate branch July 4, 2019 15:50
dvdplm added a commit that referenced this pull request Jul 4, 2019
@dvdplm
Merge branch 'master' into dp/chore/extricate-state-backend
9b60a57 
* master:
  Extract AccountDB to account-db (#10839)
  test: Update Whisper test for invalid pool size (#10811)
This was referenced Nov 5, 2019
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jam10o-new jam10o-new jam10o-new approved these changes

@ordian ordian ordian approved these changes

Assignees

@dvdplm dvdplm

Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing.
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@dvdplm @ordian @jam10o-new