This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Be more specific for -l CLI arguments
#9149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @Tbaut signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Tbaut
added
F8-enhancement 🎊
sorpaas
reviewed
Jul 17, 2018
parity/cli/mod.rs
Outdated
| @@ -800,7 +800,7 @@ usage! { | |||
|
|
|||
| ARG arg_logging: (Option<String>) = None, or |c: &Config| c.misc.as_ref()?.logging.clone(), | |||
| "-l, --logging=[LOGGING]", | |||
| "Specify the logging level. Must conform to the same format as RUST_LOG.", | |||
| "Specify the general logging level (error, warn, info, debug or trace). It can also be set for a specific module. Example: '-l sync=debug, rpc=trace', | |||
There was a problem hiding this comment.
Missing " in the end, and extra space after general. ;)
There was a problem hiding this comment.
fixed, that was obviously written too quickly :)
andresilva
approved these changes
Jul 17, 2018
parity/cli/mod.rs
Outdated
| @@ -800,7 +800,7 @@ usage! { | |||
|
|
|||
| ARG arg_logging: (Option<String>) = None, or |c: &Config| c.misc.as_ref()?.logging.clone(), | |||
| "-l, --logging=[LOGGING]", | |||
| "Specify the logging level. Must conform to the same format as RUST_LOG.", | |||
| "Specify the general logging level (error, warn, info, debug or trace). It can also be set for a specific module. Example: '-l sync=debug, rpc=trace'", | |||
sorpaas
approved these changes
Jul 17, 2018
5chdn
reviewed
Jul 17, 2018
| @@ -800,7 +800,7 @@ usage! { | |||
|
|
|||
| ARG arg_logging: (Option<String>) = None, or |c: &Config| c.misc.as_ref()?.logging.clone(), | |||
| "-l, --logging=[LOGGING]", | |||
| "Specify the logging level. Must conform to the same format as RUST_LOG.", | |||
| "Specify the general logging level (error, warn, info, debug or trace). It can also be set for a specific module, example: '-l sync=debug, rpc=trace'", | |||
There was a problem hiding this comment.
Does it really work with space between the options?
There was a problem hiding this comment.
parity -l sync=debug, rpc=trace
error: Found argument 'rpc=trace' which wasn't expected, or isn't valid in this context
USAGE:
parity [SUBCOMMAND]
For more information try --help
There was a problem hiding this comment.
Damn I tested the example but didn't copy paste it so didn't catch the space.
5chdn
added
A5-grumble 🔥
|
Stop adding F-Labels 🤣 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.