This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix Bloom migration #9992
Merged
Fix Bloom migration #9992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A0-pleasereview 🤓
|
Sorry misclick. In the future if we see issues with missing logs we should ask users whether their db migrated from 1.x to 2.x (since blooms were borked in the process). |
5chdn
added
A8-looksgood 🦄
|
@andresilva May I ask is there any ETA to update #9762 PR? Thanks. |
sorpaas
approved these changes
Nov 30, 2018
|
@naikmyeong Let's move discussions about progpow to #9762. |
5chdn
pushed a commit
that referenced
this pull request
Nov 30, 2018
* Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬
5chdn
pushed a commit
that referenced
this pull request
Nov 30, 2018
* Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬
5chdn
added a commit
that referenced
this pull request
Nov 30, 2018
* version: bump stable to 2.1.8 * Fix Bloom migration (#9992) * Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬 * Fix daemonize (#10000) * Revert "prevent silent errors in daemon mode, closes #9367 (#9946)" This reverts commit 52d5278. * deps(daemonize): switch back to crates.io * move daemonize before creating account provider (#10003) * move daemonize before creating account provider * daemonize: add a future-proofing comment
5chdn
added a commit
that referenced
this pull request
Nov 30, 2018
* version: bump beta to 2.2.3 * Fix Bloom migration (#9992) * Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬 * Fix daemonize (#10000) * Revert "prevent silent errors in daemon mode, closes #9367 (#9946)" This reverts commit 52d5278. * deps(daemonize): switch back to crates.io * move daemonize before creating account provider (#10003) * move daemonize before creating account provider * daemonize: add a future-proofing comment
niklasad1
pushed a commit
that referenced
this pull request
Dec 16, 2018
* Fix wrong block number in blooms migration * Fix wrong `const` type (usize -> u64) 😬
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9629
The bloom's block number where wrongly converted from the previous format (the index was in fact
block_number / 16, because there were16blooms per entry).