Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

handling invalid spec jsons properly, additional tests, closes #1840 #2049

Merged
merged 3 commits into from
Sep 7, 2016
Merged

handling invalid spec jsons properly, additional tests, closes #1840 #2049

merged 3 commits into from
Sep 7, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Sep 5, 2016

  • removed unsafe unwrap from Spec::load

closes #1840

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Sep 5, 2016
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Sep 6, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.076% when pulling 61d3d74 on spec_load_errors into 31cd965 on master.

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Sep 7, 2016
@rphmeier rphmeier merged commit 916ce03 into master Sep 7, 2016
@debris debris deleted the spec_load_errors branch September 7, 2016 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec loading incorrect json results in the SIGILL: illegal instruction
3 participants
@debris @coveralls @rphmeier