This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
move utility functions to api.util #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fusing, more apt)
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
tomusdrw
approved these changes
Sep 17, 2016
tomusdrw
added
A8-looksgood 🦄
jacogr
changed the title
* js: (59 commits) use standard modal title functionality fix modal title size where no steps are available get adding addresses working again (context migration) Bump clippy & Fix warnings (#2109) Added docs fix merge conflict check for existence of deprecated ethash file before attempting delete (#2103) fix grumble check response.ok, throw Error array for classlist .map -> .forEach fix wording rename fundAccount to shapeshift use shapeshift ison & name fix typo use only one image for tokens, scale it (maps what is available when pulled form IMG meta in TokenReg) Import summary unknown image when none found for a token don't show tokens.value === 0 in transfer cater for the cases where the token doesn't have an image ... # Conflicts: # js/src/modals/Transfer/Details/details.js
# Conflicts: # js/src/dapps/registry/Lookup/actions.js # js/src/dapps/registry/Status/status.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original format endpoint just exploded, and it started to not make sense from a API end-user perspective since everything in there was not formatting related and to make matters worse we started confusing the internal libraries with the external interfaces.
(Any new features added under api/format that is WIP, needs to be moved to this endpoint as well. For current code, a
s/api.format/api.util/gwill do the trick)