Fixes to the Token Registration dApp #2250
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
| if (this.state.loading || !this.state.valid) return; | ||
|
|
||
| return ( | ||
| <div className={ styles['input-icon'] }> |
There was a problem hiding this comment.
I believe styles.inputIcon may do the trick as well.
There was a problem hiding this comment.
Unfortunately, no...
|
|
||
| this.setState({ ...validation }); | ||
|
|
||
| if (validation.valid) return this.props.onChange(true, value); |
There was a problem hiding this comment.
Are you sure the linter doesn't complain here? (Single-line if)
There was a problem hiding this comment.
Yep, it doesn't, but modified it.
| @@ -185,13 +276,14 @@ export default class Token extends Component { | |||
| } | |||
|
|
|||
| onMetaLookup = () => { | |||
| let query = this.state.metaQuery; | |||
| let keyIndex = this.state.metaKeyIndex; | |||
There was a problem hiding this comment.
Should I always use const?
There was a problem hiding this comment.
Yes. Unless we need to modify things. The best approach - just use const, if you assign something and it complains, let it :)
| }) | ||
| .then(data => { | ||
| // If no total supply, must not be a proper token | ||
| if (data.totalSupply === null) { |
There was a problem hiding this comment.
does it come back at null or 0? May want to do a eth_getCode on the address first, no code found, not a contract
There was a problem hiding this comment.
Yep, the getTokenTotalSupply method is in fact doing just that, returning null if no code, or not a token contract.
jacogr
added
A8-looksgood 🦄
Small fixes for issues #2195, #2198, #2193, #2197, #2196, #2194 ...