This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Apply pending block details on commit #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably related to #2258 |
gavofyork
added
A8-looksgood 🦄
|
does indeed look like it's incorrectly failing. |
|
I don't think we should merge this until a fix is available. It will just make all our other builds fail and won't get us any closer to fixing the issue. |
|
@rphmeier @gavofyork |
arkpar
added
A7-looksgoodcantmerge 🙄
arkpar
force-pushed
the
blockchain-cache-issue
branch
from
4082eb8
to
8f4ca01
Compare
arkpar
added
A0-pleasereview 🤓
arkpar
changed the title
rphmeier
reviewed
Oct 27, 2016
| @@ -934,8 +925,10 @@ impl BlockChain { | |||
| }, | |||
| } | |||
| let mut write_hashes = self.pending_block_hashes.write(); | |||
| let mut write_details = self.pending_block_details.write(); | |||
There was a problem hiding this comment.
comment above should now say "all four locks taken"
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.