This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Auto Open/Close the Signer window on new transaction request #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @ngotchac signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
Cool. Actually realised last night that we probably need the same popup window in the main up. Unlike the dapps it is never visible, but pops out (same as here) when a new transaction come in. However not this PR. (Without this the contract deployment where we wiat become quite problematic - you cannot wait and type. Plus it will add quite a bit to the flow, i.e. don't leave the page to come back) |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few UI glitches with the Signer window, and makes it automatically open/close on new/no more request(s).
Issue #2338