This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
M4-core ⛓
Core client code / Rust.
labels
Oct 11, 2016
@winsvega any hint why there are duplicate keys? |
It was there since it was passing fine through |
keorn
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Oct 11, 2016
keorn
commented
Oct 11, 2016
@@ -36,3 +36,7 @@ declare_test!{BlockchainTests_Homestead_bcUncleHeaderValiditiy, "BlockchainTests | |||
declare_test!{BlockchainTests_Homestead_bcUncleTest, "BlockchainTests/Homestead/bcUncleTest"} | |||
declare_test!{BlockchainTests_Homestead_bcValidBlockTest, "BlockchainTests/Homestead/bcValidBlockTest"} | |||
declare_test!{BlockchainTests_Homestead_bcWalletTest, "BlockchainTests/Homestead/bcWalletTest"} | |||
declare_test!{BlockchainTests_Homestead_bcShanghaiLove, "BlockchainTests/Homestead/bcShanghaiLove"} | |||
// Uncomment once the test is correct. | |||
// declare_test!{BlockchainTests_Homestead_bcSuicideIssue, "BlockchainTests/Homestead/bcSuicideIssue"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is not yet ready in ethereum/tests
repo.
arkpar
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Oct 12, 2016
tomusdrw
pushed a commit
that referenced
this pull request
Oct 12, 2016
* update json test suite * comment out the incomplete test Conflicts: ethcore/res/ethereum/tests
arkpar
pushed a commit
that referenced
this pull request
Oct 14, 2016
* update json test suite * comment out the incomplete test Conflicts: ethcore/res/ethereum/tests
arkpar
pushed a commit
that referenced
this pull request
Oct 14, 2016
* update json test suite * comment out the incomplete test Conflicts: ethcore/res/ethereum/tests
arkpar
pushed a commit
that referenced
this pull request
Oct 15, 2016
* EIP150.1c Conflicts: ethcore/res/ethereum/expanse.json ethcore/res/ethereum/morden.json ethcore/res/ethereum/tests ethcore/src/blockchain/blockchain.rs ethcore/src/ethereum/ethash.rs ethcore/src/evm/interpreter/mod.rs json/src/spec/ethash.rs * Update json test suite (#2574) * update json test suite * comment out the incomplete test Conflicts: ethcore/res/ethereum/tests * Updating tests * Adding state tests * Updating tests * Updating HF block * Removing flushln [ci:skip] * Commenting out suicide test * New tests. * Switch to EIP tests. * Rename some stuff, combine transition tests. * Fix U256 overflows. * Name cleanups and an effort to fix tests. * Rename back for clarity. * Fix non-EIP-150 OOG CALLs * New transition block number & additional EIP150 tests * Morden transition block set; Tests updated * Added missing test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One new failing, but I think its an issue with format: