This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
sweep most unwraps from ethcore crate, dapps crate #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
reviewed
Oct 20, 2016
| self.state.add_balance(&t.sender().unwrap(), &refund_value); | ||
| let sender = match t.sender() { | ||
| Ok(sender) => sender, | ||
| Err(e) => { |
There was a problem hiding this comment.
This error is not really possible at that point (sender is validated much earlier)
There was a problem hiding this comment.
yup, but it's not ensured at compile-time. so we could either expect (which depends on a specific usage of the function, and might get broken in the future) or just do nothing whenever the constraints of the function aren't met.
rphmeier
added
A3-inprogress ⏳
|
Gonna sweep unwraps from a few more places in the codebase and roll it up together. |
rphmeier
changed the title
rphmeier
added
A0-pleasereview 🤓
rphmeier
force-pushed
the
ethcore-panic-sweep
branch
from
29e011f
to
3af2a67
Compare
[ci:none]
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1026