Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Additional RPCs for password management #2779

Merged
merged 6 commits into from
Oct 22, 2016
Merged

Additional RPCs for password management #2779

merged 6 commits into from
Oct 22, 2016

Conversation

gavofyork
Copy link
Contributor

  • personal_testPassword takes (account, password), returns isCorrect: bool
  • personal_changePassword takes (account, password, new_password), returns null

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Oct 21, 2016
rphmeier
rphmeier reviewed Oct 21, 2016
View reviewed changes
ethcore/src/account_provider.rs

/// Changes the password of `account` from `password` to `new_password`. Fails if incorrect `password` given.
pub fn change_password(&self, account: &Address, password: String, new_password: String) -> Result<(), Error> {
self.sstore.change_password(&account, &password, &new_password).map_err(|e| Error::SStore(e))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map_err(Error::SStore)

@jacogr jacogr mentioned this pull request Oct 21, 2016
Closed
@rphmeier rphmeier added M4-core ⛓ Core client code / Rust. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 21, 2016
@gavofyork gavofyork merged commit 37a2ee9 into master Oct 22, 2016
@gavofyork gavofyork deleted the rpc-test-password branch October 22, 2016 13:24
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.172% when pulling 03954b1 on rpc-test-password into 9150fce on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier left review comments

Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavofyork @coveralls @rphmeier