-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
is travis meant to pass? |
Yes. Meant to pass. I have no idea why this happens -
Have not touched that. Will re-look at it again as soon as I have a gap, just need to get through proper end-to-end UI testing for release first. |
to be honest we'll remove travis as soon as gitlab is integrated for all major platform/test combinations. |
Agreed. The only reason why this was done was because of the issues we've had with GitLab stability - had 2 merges during extended GitLab downtime (testing failures in both), that started failing builds when it came back up and put us in fire-fighting mode. In addition, the structure is much more extensive for the JS side of things on GitLab (does much more, this is very basic) so this is just a short-term failsafe so we don't end up with failing master yet again. |
Closes https://github.com/ethcore/parity/issues/2777
A tiny bit of a jiggle to get multiple languages supported, especially if the 2nd is Node - but the version is now correct and the linting/tests run on Travis. It can no doubt be optimised, but I have a day down on this and it does what it says on the tin.
As for the Travis failure, the js stuff runs and passes, it fails on this -