-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Additional changes to ethash DAG caching are required. Latest DAG should be preserved and never evicted. Otherwise we'll have significant block delays when importing new blocks with background download because the latest gets evicted by ancient checks. |
Good point. I'll see what can be done about it. In the case of manually restarted sync we will want to clear everything though; a simple rule like "always keep the DAG with the latest era" probably won't be enough. |
@gavofyork also suggested verifying total difficulty of the best block compared to what peers on the network say about it. If possible, this data should be collected before beginning the restoration of the snapshot. The manifest's block hash should also be checked against the network before beginning whenever we've got peers. Together it should be practically impossible to produce an invalid snapshot. @arkpar |
some tests would be good at some point. |
Future work: