Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

RPCs for mode change #3002

Merged
merged 5 commits into from
Oct 31, 2016
Merged

RPCs for mode change #3002

merged 5 commits into from
Oct 31, 2016

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork commented Oct 31, 2016

As desired for #2995

@jacogr all yours for adding the JS side of this.

@tomusdrw will benefit from the mode being persistent between runs - can we have previous run's mode be retained in a config file like the pruning method?

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 31, 2016
@jacogr
Copy link
Contributor

jacogr commented Oct 31, 2016

JSAPI added for ethcore_mode & ethcore_setMode

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e441c2b on ipcs-for-mode-change into * on master*.

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 31, 2016
@gavofyork gavofyork merged commit 547871f into master Oct 31, 2016
@gavofyork gavofyork deleted the ipcs-for-mode-change branch October 31, 2016 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants