-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Change contract Execute bool values & query bool value display #3024
Conversation
jacogr
commented
Oct 31, 2016
•
edited
Loading
edited
- Allow execution selection of bool values, Fixes https://github.com/ethcore/parity/issues/3023
- Display true/false as strings in query, Fixes https://github.com/ethcore/parity/issues/3025
I tested this PR and it fixes the reported issue. Although I would prefer radion buttons (one click less), this solution does the trick and removes any ambiguity from the user whether it is false, 'false', 0, 0x0.... Here there is no choice, which is the best. Now having to ability to set |
); | ||
}); | ||
inputbox = ( | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a checkbox or toggle? One click less and more semantical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Checkbox is semantically not the best option.
- Toggle could work but does not allow for undefined value (the current dropdown solution either).
- Radio buttons are good because you can have 2 states (true / false), make the entry mandatory and define neither or the states as default so the user must make a choice and he can do so in a single click.
This is a detail, the current implementation is functional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple - we don't have a proper wrapped component that fits in with the l&f of the system which includes the labels and hints (not applicable here) as it does for the other inputs. As soon as we bring in a toggle, it raises all kinds of other issues where the specific field won't fit with the rest of the generated UI at this point. So for 1.4 it will be the dropdown.
Not' going to add a different component with the required styling and labels a day before release, especially not after the issues we've had with non-standard components such as the tag inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was kinda expecting such reason. I think that for now, the dropdown is functional and integrates well in the UI.
@chevdor Added a fix for your other issue in this PR as well |
I don´t see the fix for #3025 |
Changes Unknown when pulling 374c2b3 on jg-contract-execute-bool into * on master*. |
Tested, all good now. Thank you @jacogr! |
Changes Unknown when pulling 374c2b3 on jg-contract-execute-bool into * on master*. |