-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
|
const nextTimeout = (timeout = 1000) => { | ||
setTimeout(this._pollStatus, timeout); | ||
}; | ||
|
||
if (isConnected !== this._store.getState().nodeStatus.isConnected) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const wasConnected = this._store.getState().nodeStatus.isConnected;
if (isConnected !== wasConnected) …
I think monospaced text will be better to read in this case. Also, will the enode actually be relevant to the majority of the users? This is so much text that will potentially be just noise to many users. What about putting it in a tooltip on the "x/y/z peers" text? |
Sadly we don't use monospaced fonts on the status page atm, so it would completely out of place if added. On the status page we have all the technical status settings, which is why it is not visible to users. (e.g. miner setting, mining author, ports, etc.) So the positioning is correct. Happy with what is there overall, right place, right positioning. |
i'd like to get rid of long hex strings from the UI in general. this includes at least addresses and enode ids. they're easily replaced by a copy button (in case the user actually wants them) - possibly mouse-over sensitive, and a rendering with just the first few nibbles on the front and back e.g. |
Closes #3106
Gets the enode address from the RPC call and display it.
Added it to JS API.
Needs #3096 to be merged.