This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
EIP-155 update with Vitalik's new test vectors #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
changed the title
gavofyork
added
the
P2-asap 🌊
|
A few state and transaction test failing in travis build |
arkpar
added
A4-gotissues 💥
arkpar
reviewed
Nov 4, 2016
| @@ -302,13 +302,13 @@ impl SignedTransaction { | |||
| } | |||
|
|
|||
| /// 0 if `v` would have been 27 under "Electrum" notation, 1 if 28 or 4 if invalid. | |||
| pub fn standard_v(&self) -> u8 { match self.v { 0 => 4, v => (v - 1) & 1, } } | |||
| pub fn standard_v(&self) -> u8 { match self.v { v if v == 27 || v == 28 || v > 36 => (v - 37) % 2, _ => 4 } } | |||
There was a problem hiding this comment.
Looks like v - 37 will overflow. Should just return 0 if v == 27 or 28
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Nov 4, 2016
* Vitalik's new test vectors. * Update to latest EIP155 spec. * Fix txs. * Another fix.
arkpar
pushed a commit
that referenced
this pull request
Nov 4, 2016
* Vitalik's new test vectors. * Update to latest EIP155 spec. * Fix txs. * Another fix.
arkpar
added a commit
that referenced
this pull request
Nov 4, 2016
arkpar
added a commit
that referenced
this pull request
Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.