-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Changes Unknown when pulling 0fe83ee on jg-dapp-registry into ** on master**. |
Looks really nice! A few points though:
|
The id can be anything, as long as it is unique. (We do however need to extend it a little bit shortly - people registering probably, like we do, want to use the same id on test & live. The only way to do that currently is to use the contract itself for the second network and manually specifying the id.) As for the content - Parity currently (via contentHash) only supports content on GHH, so it is currently the only methods we support. Have played with chevdor with IPFS content for manifests & images. (Using the GHH hintURL functionality.) However the UI for the .zip itself is not going to move away from serving content via Parity - it has the MITM checking for content against hash built-in, so the content is only available via |
Merging, need it for the contract & dapp deploys on ropsten (as to not doing everything again manually for the 3rd time around). |
We really don't want developers to interact with and have to understand the underlying contract to register their own apps for network access (i.e. global). This dapp provides the bare basics, registration, deletion & updates with no extra frills.
https://youtu.be/3KtGkYkai90
TODO -
Hook up to the builtins page & make available as an dapp (will be done once https://github.com/ethcore/parity/issues/3308 is in - rework the visible, hidden & external display.) Currently dapp only available via direct URL access
Update Wiki for dapp registration to reflect process (i.e. simplify, make the current error-prone descriptions simpler)
Not 100% happy with the DappStore, class became a bit too big for quick navigation.
Closes https://github.com/ethcore/parity/issues/2126