Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Handle solc combined output #3496

Merged
merged 6 commits into from
Nov 18, 2016
Merged

Handle solc combined output #3496

merged 6 commits into from
Nov 18, 2016

Conversation

ngotchac
Copy link
Contributor

Closes #3196

Add a new step to the deploy modal : choose between manual and solc generated ABI and bytecode.
If solc => Select to choose which contract to deploy.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 17, 2016
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 17, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 18e40f3 on ng-solc-output into * on master*.

@jacogr
Copy link
Contributor

jacogr commented Nov 17, 2016

Thanks, looks as discussed, doesn't get in the way (determining inputs) & cleans up the previously overload dialogs. No issues with the code either.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Nov 17, 2016
@gavofyork gavofyork merged commit dd50c63 into master Nov 18, 2016
@gavofyork gavofyork deleted the ng-solc-output branch November 18, 2016 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants