This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix peers not displaying #3561
Merged
Fix peers not displaying #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A2-insubstantial 👶
derhuerst
reviewed
Nov 21, 2016
|
|
||
| if (refreshStatus) { | ||
| statusPromises.push(this._api.eth.hashrate()); | ||
| statusPromises.push(this._api.parity.netPeers()); | ||
| } | ||
|
|
||
| Promise | ||
| .all(statusPromises) | ||
| .then((statusResults) => { |
There was a problem hiding this comment.
You could use Array destructuring here and then check for existence:
([ syncing, netPeers ]) => {
if (syncing && netPeers) {
…
}
}
There was a problem hiding this comment.
Agreed here with @derhuerst - put the optional ones at the back, check for undefined if you must (then not adding it), but just cleaner.
|
Changes Unknown when pulling 5db8591 on ng-fix-peers into ** on master**. |
ngotchac
added
A0-pleasereview 🤓
derhuerst
added
A8-looksgood 🦄
|
Changes Unknown when pulling 1d26648 on ng-fix-peers into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3558