-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New directory structure #3828
New directory structure #3828
Conversation
Changes Unknown when pulling 85fd629 on new-dirs into ** on master**. |
Seems to also close https://github.com/ethcore/parity/issues/2383 This seems much better. I assume the config file will go in |
@@ -67,7 +67,7 @@ pub struct Spec { | |||
/// What engine are we using for this? | |||
pub engine: Arc<Engine>, | |||
/// The fork identifier for this chain. Only needed to distinguish two chains sharing the same genesis. | |||
pub fork_name: Option<String>, | |||
pub data_dir: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break compatibility with previous chain specs.
Also the doc string here is now wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think anyone uses this for private chains. We use it for classic and expanse. Upgrade path for these is supported.
@@ -126,3 +129,76 @@ pub fn upgrade(db_path: Option<&str>) -> Result<usize, Error> { | |||
upgrade_from_version(ver) | |||
}) | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: whitespace
Config goes into |
Changes Unknown when pulling 5fd2e15 on new-dirs into ** on master**. |
would be good to solve https://github.com/ethcore/parity/issues/1648 in this PR too since they both need paths sorting. |
having let app_info = AppInfo { name: "parity", author: "parity" };
let db_path = try!(get_app_root(AppDataType::UserData, &app_info)); |
It even obeys XDG base dir standards :) |
Changes Unknown when pulling be5fefe on new-dirs into ** on master**. |
Changes Unknown when pulling 3280f07 on new-dirs into ** on master**. |
maybe make |
This PR introduces a new directory structure for Paritys' files. The new structure looks like this:
--db-path
and-d
now set a root path for all files (.parity
alternative).db kill
command is introduced.Closes #3683, #1221, #2383, #2374