This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update registration after every write #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
arkpar
commented
Jan 10, 2017
| } | ||
| io.update_registration(self.token)?; |
There was a problem hiding this comment.
This fixes a race condition when the sending queue is being processed and another packet is added to the queue. The registration might have not been updated in such case.
There was a problem hiding this comment.
Not too clear on the mio specifics, but does it cause any issues to reregister interest multiple times before a timeout or notify event is handled? I thought that was the original purpose of waiting until the send queue was empty.
There was a problem hiding this comment.
Calling reregister multiple times is perfectly fine.
|
Changes Unknown when pulling ce2154b on net-send-reg-update into ** on master**. |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2668