Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove onSubmit of current (no auto-change on password edit) #4151

Merged
merged 2 commits into from
Jan 12, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Jan 12, 2017

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. B0-patch labels Jan 12, 2017
@jacogr jacogr changed the title Remove onSubmit from current password Remove onSubmit of current (no auto-change) Jan 12, 2017
@jacogr jacogr changed the title Remove onSubmit of current (no auto-change) Remove onSubmit of current (no auto-change on password edit) Jan 12, 2017
@ngotchac
Copy link
Contributor

Still missed the other Inputs fields that still have the onSubmit props

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 12, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jan 12, 2017
@jacogr jacogr merged commit bff0f8e into master Jan 12, 2017
@jacogr jacogr deleted the jg-password-edit-fix branch January 12, 2017 14:18
arkpar pushed a commit that referenced this pull request Jan 13, 2017
* Remove onSubmit from current password

* Remove onSubmit from hint
arkpar added a commit that referenced this pull request Jan 13, 2017
* Remove onSubmit of current (no auto-change on password edit) (#4151)

* Remove onSubmit from current password

* Remove onSubmit from hint

* Pull in console dapp as builtin (#4145)

* Copy static dapps from static (no build)

* Console sources

* Add console to builtins

* Remove console assets

* Disable eslint on console.js

* Enable eslint after disable

* Webpack copy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants