Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Minor refactor for clarity #4174

Merged
merged 3 commits into from
Jan 17, 2017
Merged

Minor refactor for clarity #4174

merged 3 commits into from
Jan 17, 2017

Conversation

esaulpaugh
Copy link
Contributor

No description provided.

@parity-cla-bot
Copy link

It looks like @esaulpaugh hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Ethcore CLA Bot

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cf03a28 on esaulpaugh:master into ** on ethcore:master**.

@esaulpaugh esaulpaugh changed the title Spelling & grammar in TxQueue Viewer description Minor refactor for clarity Jan 15, 2017
@esaulpaugh
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @esaulpaugh signed our Contributor License Agreement. 👍

Many thanks,

Ethcore CLA Bot

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 69f83fc on esaulpaugh:master into ** on ethcore:master**.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Jan 15, 2017
jacogr
jacogr reviewed Jan 16, 2017
View reviewed changes
js/src/abi/util/address.js

for (let n = 0; n < 40; n++) {
const char = address[n];
const isLower = char != char.toUpperCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use !== (here and line below)

@jacogr
Copy link
Contributor

jacogr commented Jan 16, 2017 •
edited
Loading 

parity/js/src/abi/util/address.js
  25:26  error  Expected '!==' and instead saw '!='  eqeqeq
  26:26  error  Expected '!==' and instead saw '!='  eqeqeq

Thanks for the contribution. As a rule, both npm run lint & npm run test should pass, small oversight here.

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 16, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jan 17, 2017
@gavofyork gavofyork merged commit 7dde80f into openethereum:master Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@esaulpaugh @parity-cla-bot @coveralls @jacogr @gavofyork @keorn